starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10621] [MERGED] Optimize hot path in textBufferCellIterator #28148

New Issue
Open
opened 2026-01-31 09:26:38 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:26:38 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10621
Author: @skyline75489
Created: 7/12/2021
Status: ✅ Merged
Merged: 7/27/2021
Merged by: @undefined

Base: main ← Head: chesterliu/dev/tbci-hotpath

📝 Commits (10+)

📊 Changes

3 files changed (+114 additions, -10 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+1 -0)
📝 src/buffer/out/OutputCellView.hpp (+16 -1)
📝 src/buffer/out/textBufferCellIterator.cpp (+97 -9)

📄 Description

Summary of the Pull Request

References

The += operator is an extremely hot path under heavily output load. This PR aims to optimize its speed.

PR Checklist

  • Supports What about 'over all windows' as Task Manager? (#10563)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10621 **Author:** [@skyline75489](https://github.com/skyline75489) **Created:** 7/12/2021 **Status:** ✅ Merged **Merged:** 7/27/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `chesterliu/dev/tbci-hotpath` --- ### 📝 Commits (10+) - [`3f67edf`](https://github.com/microsoft/terminal/commit/3f67edf876f727fa331416bfb6118c39b62dce77) Optimize hot path in textBufferCellIterator - [`8aadccb`](https://github.com/microsoft/terminal/commit/8aadccbb8ad88ba8fc874c6627a4432d0c699b65) Merge branch 'main' into chesterliu/dev/tbci-hotpath - [`7feea77`](https://github.com/microsoft/terminal/commit/7feea77fe005cea3f66916690ba4ada05711fe92) Update - [`737fe3c`](https://github.com/microsoft/terminal/commit/737fe3cdaffbb54b4de33ede08b30550a670a461) Restore functionailty - [`f04c94e`](https://github.com/microsoft/terminal/commit/f04c94ea8bb83649210a7886b9f378b81d431b0f) Format - [`53cfb27`](https://github.com/microsoft/terminal/commit/53cfb274df2c9933d3aadd0d397cdbbc64228c5b) review - [`7ed2a76`](https://github.com/microsoft/terminal/commit/7ed2a76730649f07c1e4dd928ab7a9a296ad9e3f) U got me, bot - [`050dc7e`](https://github.com/microsoft/terminal/commit/050dc7e8a968215779b5a9911ee1ce8e82c0a10e) Merge branch 'main' into chesterliu/dev/tbci-hotpath - [`8753573`](https://github.com/microsoft/terminal/commit/87535731fa0af3bb3b7d73677bcf6314a784ed19) Minor code cleanup - [`2a12085`](https://github.com/microsoft/terminal/commit/2a120859c0ded914a4d81a117d712889fd2f5e1a) Fix spelling ### 📊 Changes **3 files changed** (+114 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+1 -0) 📝 `src/buffer/out/OutputCellView.hpp` (+16 -1) 📝 `src/buffer/out/textBufferCellIterator.cpp` (+97 -9) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References The `+=` operator is an extremely hot path under heavily output load. This PR aims to optimize its speed. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Supports #10563 * [ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:38 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?