[PR #10646] [MERGED] Upgrade check-spelling to v0.0.19 #28154

Open
opened 2026-01-31 09:26:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10646
Author: @jsoref
Created: 7/13/2021
Status: ✅ Merged
Merged: 7/13/2021
Merged by: @DHowett

Base: main ← Head: main-spelling-0.0.19


📝 Commits (1)

  • 8a97d91 Upgrade check-spelling to v0.0.19

📊 Changes

6 files changed (+24 additions, -18 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+1 -0)
📝 .github/actions/spelling/allow/apis.txt (+7 -0)
📝 .github/actions/spelling/allow/fonts.txt (+1 -0)
📝 .github/actions/spelling/allow/microsoft.txt (+3 -0)
📝 .github/actions/spelling/expect/expect.txt (+7 -14)
📝 .github/workflows/spelling2.yml (+5 -4)

📄 Description

Summary of the Pull Request

Updates check-spelling to 0.0.19

References

https://github.com/check-spelling/check-spelling/security/advisories/GHSA-g86g-chm8-7r2p

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

I'm pinning actions/checkout to @v2 instead of micromanaging the version. We have reasonable faith that GitHub will do a good job of maintaining their version branch.

I'll probably introduce a version branch for check-spelling in the near future as well.
The job name change is for future bits -- I originally copied the name from a template and didn't understand its significance -- eventually it'll actually be used by the workflow. And if one uses act, having distinct / well named jobs is actually useful.

Validation Steps Performed

https://github.com/jsoref/terminal/actions/runs/1025581435 is a previous run where I still had some unrecognized words.

https://github.com/jsoref/terminal/actions/runs/1025602647 is this passing run.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10646 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 7/13/2021 **Status:** ✅ Merged **Merged:** 7/13/2021 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `main-spelling-0.0.19` --- ### 📝 Commits (1) - [`8a97d91`](https://github.com/microsoft/terminal/commit/8a97d91b634e3d39d8c33b383b5588358ee68ac2) Upgrade check-spelling to v0.0.19 ### 📊 Changes **6 files changed** (+24 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+1 -0) 📝 `.github/actions/spelling/allow/apis.txt` (+7 -0) 📝 `.github/actions/spelling/allow/fonts.txt` (+1 -0) 📝 `.github/actions/spelling/allow/microsoft.txt` (+3 -0) 📝 `.github/actions/spelling/expect/expect.txt` (+7 -14) 📝 `.github/workflows/spelling2.yml` (+5 -4) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Updates check-spelling to 0.0.19 <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References https://github.com/check-spelling/check-spelling/security/advisories/GHSA-g86g-chm8-7r2p <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments I'm pinning `actions/checkout` to @v2 instead of micromanaging the version. We have reasonable faith that GitHub will do a good job of maintaining their version branch. I'll probably introduce a version branch for check-spelling in the near future as well. The job name change is for future bits -- I originally copied the name from a template and didn't understand its significance -- eventually it'll actually be used by the workflow. And if one uses `act`, having distinct / well named jobs is actually useful. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed https://github.com/jsoref/terminal/actions/runs/1025581435 is a previous run where I still had some unrecognized words. https://github.com/jsoref/terminal/actions/runs/1025602647 is this passing run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28154