[PR #10648] [CLOSED] Add a setting for disabling rendering "intense" text as bold #28155

Open
opened 2026-01-31 09:26:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10648
Author: @zadjii-msft
Created: 7/13/2021
Status: Closed

Base: mainHead: dev/migrie/f/10576-disable-intense-is-bold


📝 Commits (4)

  • 65dd64d This does the whole thing
  • a48bf19 Merge remote-tracking branch 'origin/main' into dev/migrie/f/10576-disable-intense-is-bold
  • 92ec348 add to schema too
  • 493b382 nits

📊 Changes

15 files changed (+57 additions, -2 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+5 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+3 -0)
📝 src/cascadia/TerminalControl/IControlAppearance.idl (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+3 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+10 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+5 -1)
📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp (+4 -0)
📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.h (+2 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/IAppearanceConfig.idl (+2 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.h (+2 -0)
📝 src/renderer/dx/DxRenderer.cpp (+13 -1)
📝 src/renderer/dx/DxRenderer.hpp (+3 -0)

📄 Description

Summary of the Pull Request

This adds a new setting disableIntenseIsBold. It's a per-appearance, control setting, defaulting to false.

  • When set to false, we'll render text formatted with ^[[1m as bold. (the 1.10+ default)
  • When set to true, we won't. (the pre-1.10 behavior)

PR Checklist

Validation Steps Performed

image

Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10648 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/13/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/migrie/f/10576-disable-intense-is-bold` --- ### 📝 Commits (4) - [`65dd64d`](https://github.com/microsoft/terminal/commit/65dd64d9673e86b8ee7525fa4d60ef25c41b4797) This does the whole thing - [`a48bf19`](https://github.com/microsoft/terminal/commit/a48bf192c012403ac9760ea1d8f2609af364e3e0) Merge remote-tracking branch 'origin/main' into dev/migrie/f/10576-disable-intense-is-bold - [`92ec348`](https://github.com/microsoft/terminal/commit/92ec348ac305b0b64c309aaf7bcf5775f5b1fca5) add to schema too - [`493b382`](https://github.com/microsoft/terminal/commit/493b382c58fd42440eebeefe1b76ab1d4df5b48e) nits ### 📊 Changes **15 files changed** (+57 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+5 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+3 -0) 📝 `src/cascadia/TerminalControl/IControlAppearance.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+3 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+10 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+5 -1) 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp` (+4 -0) 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/IAppearanceConfig.idl` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.h` (+2 -0) 📝 `src/renderer/dx/DxRenderer.cpp` (+13 -1) 📝 `src/renderer/dx/DxRenderer.hpp` (+3 -0) </details> ### 📄 Description ## Summary of the Pull Request This adds a new setting `disableIntenseIsBold`. It's a per-appearance, control setting, defaulting to `false`. * When set to false, we'll render text formatted with `^[[1m` as **bold**. (the 1.10+ default) * When set to true, we won't. (the pre-1.10 behavior) ## PR Checklist * [x] Closes #10576 * [x] I work here * [ ] Tests added/passed - nah I didn't do that * [n/a] Requires documentation to be updated ## Validation Steps Performed ![image](https://user-images.githubusercontent.com/18356694/125480327-07f6b711-6bca-4c1b-9a76-75fc978c702d.png) Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28155