starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10642] [MERGED] Fix mouse coordinates when viewport is scrolled #28156

New Issue
Open
opened 2026-01-31 09:26:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:26:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10642
Author: @PankajBhojwani
Created: 7/13/2021
Status: ✅ Merged
Merged: 7/20/2021
Merged by: @undefined

Base: main ← Head: dev/pabhoj/mouse_viewport_fix

📝 Commits (10+)

📊 Changes

2 files changed (+96 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlInteractivity.cpp (+6 -1)
📝 src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp (+90 -0)

📄 Description

Summary of the Pull Request

Adjust the y-coordinate of the mouse coordinates we send based on how much the viewport has been scrolled

Validation Steps Performed

Validated: cannot repro the issue in #10190

Closes #10190

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10642 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 7/13/2021 **Status:** ✅ Merged **Merged:** 7/20/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/mouse_viewport_fix` --- ### 📝 Commits (10+) - [`ecacf2b`](https://github.com/microsoft/terminal/commit/ecacf2bf2e5a843e340aa43fe176b95c7cdd5d57) adjust sent coord - [`7f97dfd`](https://github.com/microsoft/terminal/commit/7f97dfd53c112e8bda240c0a6d7aa97b632b25fb) ignore clicks outside active region - [`3e38fb2`](https://github.com/microsoft/terminal/commit/3e38fb2e34422e2dca16aa88f08656720478ac40) readability - [`9867c88`](https://github.com/microsoft/terminal/commit/9867c8852254b9992c0e514701114af39ff18f85) fix - [`b4e1aea`](https://github.com/microsoft/terminal/commit/b4e1aea18921d8df6601392317ee4d65f025ff67) has - [`52a19da`](https://github.com/microsoft/terminal/commit/52a19da4ff044460f8ee3d00264787ae258a92fe) test - [`a7ce069`](https://github.com/microsoft/terminal/commit/a7ce069241fca0840472cadb96a797d1aa7fbb33) dont need nomousedown - [`02f9aa3`](https://github.com/microsoft/terminal/commit/02f9aa3eac531964283b2fcdd6ac49160835e461) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/mouse_viewport_fix - [`a2892f0`](https://github.com/microsoft/terminal/commit/a2892f056776b007074a486350f9ec0279318817) Merge branch 'dev/pabhoj/mouse_viewport_fix' of https://github.com/microsoft/terminal into dev/pabhoj/mouse_viewport_fix - [`8976a22`](https://github.com/microsoft/terminal/commit/8976a22a60fcb7f846452a934f40ae5f6c875ebe) conflict ### 📊 Changes **2 files changed** (+96 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlInteractivity.cpp` (+6 -1) 📝 `src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp` (+90 -0) </details> ### 📄 Description ## Summary of the Pull Request Adjust the y-coordinate of the mouse coordinates we send based on how much the viewport has been scrolled ## Validation Steps Performed Validated: cannot repro the issue in #10190 Closes #10190 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?