starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10653] [MERGED] Fix output stuttering using a ticket lock #28168

New Issue
Open
opened 2026-01-31 09:26:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:26:45 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10653
Author: @lhecker
Created: 7/14/2021
Status: ✅ Merged
Merged: 7/15/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/ticket-lock

📝 Commits (2)

  • e683f21 Fix output stuttering using a ticket lock
  • b52a9c1 Address reviewer comments

📊 Changes

7 files changed (+111 additions, -22 deletions)

View changed files

📝 src/cascadia/PublicTerminalCore/HwndTerminal.cpp (+6 -11)
📝 src/cascadia/PublicTerminalCore/HwndTerminal.hpp (+1 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+4 -4)
📝 src/cascadia/TerminalCore/Terminal.hpp (+13 -4)
📝 src/cascadia/TerminalCore/terminalrenderdata.cpp (+2 -2)
➕ src/inc/til/atomic.h (+29 -0)
➕ src/inc/til/ticket_lock.h (+56 -0)

📄 Description

SRWLOCK, as used by std::shared_mutex, is a inherently unfair mutex
and makes no guarantee whatsoever whether a thread may acquire the lock
in a timely manner. This is problematic for our renderer which relies on
being able to acquire the lock in a timely and predictable manner.
Drawing stalls of up to one minute have been observed in tests.

This issue can be solved with a primitive ticket lock, which is 10x
slower than a SRWLOCK but still sufficiently fast for our use case
(10M locks per second per thread). It's likely that any non-trivial lock
duration will diminish the difference to "negligible".

Validation Steps Performed

  • It still blends ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10653 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 7/14/2021 **Status:** ✅ Merged **Merged:** 7/15/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/ticket-lock` --- ### 📝 Commits (2) - [`e683f21`](https://github.com/microsoft/terminal/commit/e683f21ed73052e5766415831d7f15141b1a4bd8) Fix output stuttering using a ticket lock - [`b52a9c1`](https://github.com/microsoft/terminal/commit/b52a9c1e56feba0a0b3f91a45854aeaa581c247e) Address reviewer comments ### 📊 Changes **7 files changed** (+111 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/PublicTerminalCore/HwndTerminal.cpp` (+6 -11) 📝 `src/cascadia/PublicTerminalCore/HwndTerminal.hpp` (+1 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+4 -4) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+13 -4) 📝 `src/cascadia/TerminalCore/terminalrenderdata.cpp` (+2 -2) ➕ `src/inc/til/atomic.h` (+29 -0) ➕ `src/inc/til/ticket_lock.h` (+56 -0) </details> ### 📄 Description `SRWLOCK`, as used by `std::shared_mutex`, is a inherently unfair mutex and makes no guarantee whatsoever whether a thread may acquire the lock in a timely manner. This is problematic for our renderer which relies on being able to acquire the lock in a timely and predictable manner. Drawing stalls of up to one minute have been observed in tests. This issue can be solved with a primitive ticket lock, which is 10x slower than a `SRWLOCK` but still sufficiently fast for our use case (10M locks per second per thread). It's likely that any non-trivial lock duration will diminish the difference to "negligible". ## Validation Steps Performed * It still blends ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?