[PR #10674] [MERGED] Re-evaluate the size of the quake window when it's summoned to a monitor #28174

Open
opened 2026-01-31 09:26:47 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10674
Author: @zadjii-msft
Created: 7/15/2021
Status: Merged
Merged: 7/20/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/10274-10182-reevaluate-quake-size


📝 Commits (1)

📊 Changes

1 file changed (+7 additions, -0 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+7 -0)

📄 Description

Summary of the Pull Request

When the quake window is moved to another monitor, re-evaluate it's size for that monitor.

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews.

Validation Steps Performed

Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10674 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/15/2021 **Status:** ✅ Merged **Merged:** 7/20/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/10274-10182-reevaluate-quake-size` --- ### 📝 Commits (1) - [`6959b31`](https://github.com/microsoft/terminal/commit/6959b312c975d5ded9a205868bc23ad26387bb24) Fixes #10274, Fixes #10182 ### 📊 Changes **1 file changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+7 -0) </details> ### 📄 Description ## Summary of the Pull Request When the quake window is moved to another monitor, re-evaluate it's size for that monitor. ## References * megathread: #8888 * Similar, but not the same: #10274 ## PR Checklist * [x] Closes #10182 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Detailed Description of the Pull Request / Additional comments We'll probably need to do this in a few more places, but I'm breaking PRs into small chunks for easier reviews. ## Validation Steps Performed Summoned the window to a bunch of different resolutions. Where it would use the wrong size before, it no longer does. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:47 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28174