[PR #10676] [MERGED] Prevent the quake window's borders from hanging onto adjacent monitors #28184

Open
opened 2026-01-31 09:26:50 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10676
Author: @zadjii-msft
Created: 7/15/2021
Status: Merged
Merged: 7/20/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/10201-1px-of-quake


📝 Commits (1)

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+5 -2)

📄 Description

Summary of the Pull Request

We were making the quake window exactly the width of the monitor it was on, but that didn't account for the 1px of border on either side.

References

PR Checklist

Validation Steps Performed

It happened before, it doesn't anymore.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10676 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/15/2021 **Status:** ✅ Merged **Merged:** 7/20/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/10201-1px-of-quake` --- ### 📝 Commits (1) - [`45c6354`](https://github.com/microsoft/terminal/commit/45c6354f65ecfd20e2435f19c897eb0a0b51b939) fixes #10201 ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+5 -2) </details> ### 📄 Description ## Summary of the Pull Request We were making the quake window exactly the width of the monitor it was on, but that didn't account for the 1px of border on either side. ## References * megathread: #8888 ## PR Checklist * [x] Closes #10201 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed It happened before, it doesn't anymore. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:26:50 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28184