[PR #10756] [MERGED] Update NavigateFocus function to use new visual-based navigation #28214

Open
opened 2026-01-31 09:27:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10756
Author: @Rosefield
Created: 7/22/2021
Status: ✅ Merged
Merged: 7/23/2021
Merged by: @undefined

Base: main ← Head: feature/GH2398-visual-move-focus


📝 Commits (1)

  • dc3be30 Update NavigateFocus function to use new visual-based navigation

📊 Changes

2 files changed (+15 additions, -60 deletions)

View changed files

📝 src/cascadia/TerminalApp/Pane.cpp (+15 -59)
📝 src/cascadia/TerminalApp/Pane.h (+0 -1)

📄 Description

Summary of the Pull Request

Uses the new logic to find visual neighbors of a pane to find which pane is the target when the move-focus commands are used.

References

It sounds like this logic will be refined later to meet #4692

PR Checklist

  • Closes Add support for a separate color / image for padding area background (#2398)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Created a grid of panes and confirmed that focus movement went to the right quadrant instead of just the first child of the sibling.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10756 **Author:** [@Rosefield](https://github.com/Rosefield) **Created:** 7/22/2021 **Status:** ✅ Merged **Merged:** 7/23/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `feature/GH2398-visual-move-focus` --- ### 📝 Commits (1) - [`dc3be30`](https://github.com/microsoft/terminal/commit/dc3be30694b9c05e3ea5adaf41f196be625bb423) Update NavigateFocus function to use new visual-based navigation ### 📊 Changes **2 files changed** (+15 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Pane.cpp` (+15 -59) 📝 `src/cascadia/TerminalApp/Pane.h` (+0 -1) </details> ### 📄 Description ## Summary of the Pull Request Uses the new logic to find visual neighbors of a pane to find which pane is the target when the move-focus commands are used. ## References It sounds like this logic will be refined later to meet #4692 ## PR Checklist * [x] Closes #2398 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx ## Validation Steps Performed Created a grid of panes and confirmed that focus movement went to the right quadrant instead of just the first child of the sibling. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28214