starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10759] [MERGED] Add an ENUM setting for disabling rendering "intense" text as bold #28216

New Issue
Open
opened 2026-01-31 09:27:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:05 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10759
Author: @zadjii-msft
Created: 7/22/2021
Status: ✅ Merged
Merged: 8/16/2021
Merged by: @undefined

Base: main ← Head: dev/migrie/bold-setting-try-2

📝 Commits (10+)

  • ccf5a0e Add a setting for 'intense is bold', but backed by an enum, instead of a bool
  • c16412b Merge remote-tracking branch 'origin/main' into dev/migrie/bold-setting-try-2
  • 8ab373b Implement support for bold-is-bright in TextAttribute, write test
  • 4b74320 plumb the setting through. The SUI for this is weird now though.
  • 8a3b7ee pretty close, but we can't revert the setting?
  • f9393ce derp
  • 55cbba3 okay I don't know what I'm missing
  • cbf3022 Thanks carlos
  • b8548fe schema for carlos
  • 6c59afd Merge remote-tracking branch 'origin/main' into dev/migrie/bold-setting-try-2

📊 Changes

29 files changed (+208 additions, -8 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+11 -0)
📝 src/buffer/out/TextAttribute.cpp (+5 -3)
📝 src/buffer/out/TextAttribute.hpp (+2 -1)
📝 src/buffer/out/ut_textbuffer/TextAttributeTests.cpp (+54 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+3 -0)
📝 src/cascadia/TerminalControl/IControlAppearance.idl (+2 -0)
📝 src/cascadia/TerminalCore/ICoreAppearance.idl (+1 -0)
📝 src/cascadia/TerminalCore/Terminal.cpp (+3 -1)
📝 src/cascadia/TerminalCore/Terminal.hpp (+1 -0)
📝 src/cascadia/TerminalCore/terminalrenderdata.cpp (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+21 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+3 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+4 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+18 -0)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+25 -1)
📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp (+4 -0)
📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.cpp (+1 -0)
📝 src/cascadia/TerminalSettingsModel/EnumMappings.h (+1 -0)

...and 9 more files

📄 Description

Summary of the Pull Request

This adds a new setting intenseTextStyle. It's a per-appearance, control setting, defaulting to "all".

  • When set to "all" or ["bold", "bright"], then we'll render text as both bold and bright (1.10 behavior)
  • When set to "bold", ["bold"], we'll render text formatted with ^[[1m as bold, but not bright
  • When set to "bright", ["bright"], we'll render text formatted with ^[[1m as bright, but not bold. This is the pre 1.10 behavior
  • When set to "none", we won't do anything special for it at all.

references

  • I last did this in #10648. This time it's an enum, so we can add bright in the future. It's got positive wording this time.
  • We will want to add "bright" as a value in the future, to disable the auto intense->bright conversion. I just did that now.
  • #5682 is related

PR Checklist

Validation Steps Performed

image

Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray.

EDIT, 10 Aug

"intenseTextStyle": "none",
"intenseTextStyle": "bold",
"intenseTextStyle": "bright",
"intenseTextStyle": "all",
"intenseTextStyle": ["bold", "bright"],

all work now. Repro script:

printf "\e[1m[bold]\e[m[normal]\e[34m[blue]\e[1m[bold blue]\e[m\n"

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10759 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 7/22/2021 **Status:** ✅ Merged **Merged:** 8/16/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/bold-setting-try-2` --- ### 📝 Commits (10+) - [`ccf5a0e`](https://github.com/microsoft/terminal/commit/ccf5a0e5723b9b1d44f70317446f9b52ed73ec60) Add a setting for 'intense is bold', but backed by an enum, instead of a bool - [`c16412b`](https://github.com/microsoft/terminal/commit/c16412b06ee5a578a00372706541f599e8f0f107) Merge remote-tracking branch 'origin/main' into dev/migrie/bold-setting-try-2 - [`8ab373b`](https://github.com/microsoft/terminal/commit/8ab373bce7aee717d88e8268b02d1600e48a0151) Implement support for bold-is-bright in TextAttribute, write test - [`4b74320`](https://github.com/microsoft/terminal/commit/4b7432094b32c2e12ea7b86c341e531648413e50) plumb the setting through. The SUI for this is weird now though. - [`8a3b7ee`](https://github.com/microsoft/terminal/commit/8a3b7eef95389bc4b5628e0d480b5508bbf40eaf) pretty close, but we can't revert the setting? - [`f9393ce`](https://github.com/microsoft/terminal/commit/f9393ce4eba384011a2b8a68fe430d392c74c5af) derp - [`55cbba3`](https://github.com/microsoft/terminal/commit/55cbba369a0d147aa0c03e665efbcd63e7db0147) okay I don't know what I'm missing - [`cbf3022`](https://github.com/microsoft/terminal/commit/cbf302230eb3ac1eb46fec58388abd0d8f992900) Thanks carlos - [`b8548fe`](https://github.com/microsoft/terminal/commit/b8548fec4339abb11abb2c2b9af3b7e8003bc4fe) schema for carlos - [`6c59afd`](https://github.com/microsoft/terminal/commit/6c59afd89bb573fe11e4683c993d806e0f011c87) Merge remote-tracking branch 'origin/main' into dev/migrie/bold-setting-try-2 ### 📊 Changes **29 files changed** (+208 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+11 -0) 📝 `src/buffer/out/TextAttribute.cpp` (+5 -3) 📝 `src/buffer/out/TextAttribute.hpp` (+2 -1) 📝 `src/buffer/out/ut_textbuffer/TextAttributeTests.cpp` (+54 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+3 -0) 📝 `src/cascadia/TerminalControl/IControlAppearance.idl` (+2 -0) 📝 `src/cascadia/TerminalCore/ICoreAppearance.idl` (+1 -0) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+3 -1) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+1 -0) 📝 `src/cascadia/TerminalCore/terminalrenderdata.cpp` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+21 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+3 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+4 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+18 -0) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+25 -1) 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp` (+4 -0) 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.cpp` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/EnumMappings.h` (+1 -0) _...and 9 more files_ </details> ### 📄 Description ## Summary of the Pull Request This adds a new setting `intenseTextStyle`. It's a per-appearance, control setting, defaulting to `"all"`. * When set to `"all"` or `["bold", "bright"]`, then we'll render text as both **bold** and bright (1.10 behavior) * When set to `"bold"`, `["bold"]`, we'll render text formatted with `^[[1m` as **bold**, but not bright * When set to `"bright"`, `["bright"]`, we'll render text formatted with `^[[1m` as bright, but not bold. This is the pre 1.10 behavior * When set to `"none"`, we won't do anything special for it at all. ## references * I last did this in #10648. This time it's an enum, so we can add bright in the future. It's got positive wording this time. * ~We will want to add `"bright"` as a value in the future, to disable the auto intense->bright conversion.~ I just did that now. * #5682 is related ## PR Checklist * [x] Closes #10576 * [x] I seriously don't think we have an issue for "disable intense is bright", but I'm not crazy, people wanted that, right? https://github.com/microsoft/terminal/issues/2916#issuecomment-544880423 was the closest * [x] I work here * [x] Tests added/passed * [x] https://github.com/MicrosoftDocs/terminal/pull/381 ## Validation Steps Performed <!-- ![image](https://user-images.githubusercontent.com/18356694/125480327-07f6b711-6bca-4c1b-9a76-75fc978c702d.png) --> ![image](https://user-images.githubusercontent.com/18356694/128929228-504933ee-cf50-43a2-9982-55110ba39191.png) Yea that works. Printed some bold text, toggled it on, the text was no longer bold. hooray. ### EDIT, 10 Aug ```json "intenseTextStyle": "none", "intenseTextStyle": "bold", "intenseTextStyle": "bright", "intenseTextStyle": "all", "intenseTextStyle": ["bold", "bright"], ``` all work now. Repro script: ```sh printf "\e[1m[bold]\e[m[normal]\e[34m[blue]\e[1m[bold blue]\e[m\n" ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28216
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?