starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10777] [CLOSED] [DRAFT] Use Font Set filtering/matching to better resolve complex name specifications #28224

New Issue
Open
opened 2026-01-31 09:27:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:08 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10777
Author: @miniksa
Created: 7/23/2021
Status: ❌ Closed

Base: main ← Head: dev/miniksa/win10_font_matching

📝 Commits (2)

📊 Changes

2 files changed (+79 additions, -8 deletions)

View changed files

📝 src/renderer/dx/DxFontInfo.cpp (+75 -7)
📝 src/renderer/dx/DxFontInfo.h (+4 -1)

📄 Description

Not ready for review. Go away.

TODO:

  • - Check that invoking with names that contain weight suffixes works
  • - Determine the proper hierarchy of weight/stretch/style versus the specified name when reducing font sets.
  • - Chill out the fallback and warning messages when something appropriate is resolved but the names don't match quite right.

Closes #9744

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10777 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 7/23/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/miniksa/win10_font_matching` --- ### 📝 Commits (2) - [`61c830e`](https://github.com/microsoft/terminal/commit/61c830e3933cd6031a3d2bdbf239f2847f3329e6) Attempt to use FontSet for more complex lookup of font sets so user specified names have a better chance of matching. - [`5a210e0`](https://github.com/microsoft/terminal/commit/5a210e05f817fa636f9b3492ba15cdaadae55d45) https://docs.microsoft.com/en-us/windows/win32/api/dwrite_3/ns-dwrite_3-dwrite_font_property says to leave locale blank for filtering. ### 📊 Changes **2 files changed** (+79 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/dx/DxFontInfo.cpp` (+75 -7) 📝 `src/renderer/dx/DxFontInfo.h` (+4 -1) </details> ### 📄 Description Not ready for review. Go away. TODO: - [ ] - Check that invoking with names that contain weight suffixes works - [ ] - Determine the proper hierarchy of weight/stretch/style versus the specified name when reducing font sets. - [ ] - Chill out the fallback and warning messages when something appropriate is resolved but the names don't match quite right. Closes #9744 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28224
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?