starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10832] [MERGED] Add Split Tab option to tab context menu #28246

New Issue
Open
opened 2026-01-31 09:27:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10832
Author: @cinnamon-msft
Created: 7/30/2021
Status: ✅ Merged
Merged: 8/5/2021
Merged by: @undefined

Base: main ← Head: cinnamon/fhl/splitpane-contextmenu

📝 Commits (10+)

📊 Changes

6 files changed (+88 additions, -7 deletions)

View changed files

📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+4 -1)
📝 src/cascadia/TerminalApp/TabManagement.cpp (+24 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+33 -6)
📝 src/cascadia/TerminalApp/TerminalPage.h (+7 -0)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+19 -0)
📝 src/cascadia/TerminalApp/TerminalTab.h (+1 -0)

📄 Description

Summary of the Pull Request

Adds the Split Tab option to the tab context menu.
Clicking this option will auto split the active pane of the tab into a duplicate pane.
Clicking on an unfocused tab and splitting it will bring that tab into focus and split its active pane.

We could make this a flyout from the context menu to let people choose horizontal/vertical split in the future if it's requested.

I'm also wondering if this should be called Split Pane instead of Split Tab?

References

#1912

PR Checklist

  • Closes Add keybinding: moveTabLeft, moveTabRight (#5025)
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

https://user-images.githubusercontent.com/48369326/127691919-aae4683a-212a-4525-a0eb-a61c877461ed.mp4

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10832 **Author:** [@cinnamon-msft](https://github.com/cinnamon-msft) **Created:** 7/30/2021 **Status:** ✅ Merged **Merged:** 8/5/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `cinnamon/fhl/splitpane-contextmenu` --- ### 📝 Commits (10+) - [`aeab433`](https://github.com/microsoft/terminal/commit/aeab43386d6810706791ac68ed64948cfc8fde57) this works, probably needs to be cleaned up - [`65162e7`](https://github.com/microsoft/terminal/commit/65162e794936e6ed8dd0509c6a941c7f503012ff) code cleanup - [`7fe2e18`](https://github.com/microsoft/terminal/commit/7fe2e181e5bd92f8687284f50ed6314e02244778) code formatting - [`592d238`](https://github.com/microsoft/terminal/commit/592d23878750d015be1124976d813361bc34e348) remove unnecessary function call - [`e9d5073`](https://github.com/microsoft/terminal/commit/e9d50735acfbf49549e347367b675a09ef6c58ed) remove duplicate code - [`688616f`](https://github.com/microsoft/terminal/commit/688616f3c410acfeef443c5941cb38f2adfab646) Merge branch 'main' into cinnamon/fhl/splitpane-contextmenu - [`e96d152`](https://github.com/microsoft/terminal/commit/e96d1525970d26e8c388bfc2cbd7fb817034cbda) code formatting - [`71ff006`](https://github.com/microsoft/terminal/commit/71ff00668a56995423ed9023553108db1c4a4ae6) Merge branch 'cinnamon/fhl/splitpane-contextmenu' of https://github.com/microsoft/terminal into cinnamon/fhl/splitpane-contextmenu - [`13a5036`](https://github.com/microsoft/terminal/commit/13a503648122810b33598e12b9852d86fa6ec1f0) remove more stuff - [`31b3b81`](https://github.com/microsoft/terminal/commit/31b3b816558eca6674e96bd7b2f8a305f0a64c17) Update src/cascadia/TerminalApp/TerminalPage.cpp ### 📊 Changes **6 files changed** (+88 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+4 -1) 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+24 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+33 -6) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+7 -0) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+19 -0) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+1 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds the Split Tab option to the tab context menu. Clicking this option will `auto` split the active pane of the tab into a duplicate pane. Clicking on an unfocused tab and splitting it will bring that tab into focus and split its active pane. We could make this a flyout from the context menu to let people choose horizontal/vertical split in the future if it's requested. I'm also wondering if this should be called Split Pane instead of Split Tab? <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References #1912 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #5025 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments https://user-images.githubusercontent.com/48369326/127691919-aae4683a-212a-4525-a0eb-a61c877461ed.mp4 <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?