[PR #10821] [CLOSED] Add support for a HighlightCursor keybinding #28248

Open
opened 2026-01-31 09:27:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10821
Author: @PankajBhojwani
Created: 7/29/2021
Status: Closed

Base: mainHead: dev/pabhoj/cursor_light


📝 Commits (10+)

📊 Changes

33 files changed (+1484 additions, -914 deletions)

View changed files

.github/actions/spelling/README.md (+15 -0)
📝 .github/actions/spelling/advice.md (+16 -18)
📝 .github/actions/spelling/allow/allow.txt (+39 -3)
📝 .github/actions/spelling/allow/apis.txt (+58 -2)
📝 .github/actions/spelling/allow/math.txt (+8 -0)
📝 .github/actions/spelling/allow/microsoft.txt (+12 -0)
📝 .github/actions/spelling/allow/names.txt (+12 -0)
.github/actions/spelling/candidate.patterns (+523 -0)
📝 .github/actions/spelling/excludes.txt (+43 -5)
📝 .github/actions/spelling/expect/alphabet.txt (+0 -8)
📝 .github/actions/spelling/expect/expect.txt (+183 -735)
📝 .github/actions/spelling/expect/web.txt (+0 -11)
.github/actions/spelling/line_forbidden.patterns (+62 -0)
📝 .github/actions/spelling/patterns/patterns.txt (+78 -8)
📝 .github/actions/spelling/reject.txt (+9 -19)
📝 .github/workflows/spelling2.yml (+123 -9)
📝 doc/cascadia/profiles.schema.json (+13 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+10 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+17 -1)
📝 src/cascadia/TerminalControl/ControlCore.h (+3 -0)

...and 13 more files

📄 Description

Summary of the Pull Request

Adds a new keybinding, HighlightCursor, that darkens the entire screen except for the cursor location, allowing users to easily locate the cursor (see gif below)

Pressing the keybinding highlights the cursor location and causes the light to follow the cursor as output/scrolling happens. Pressing the keybinding again returns the terminal to the normal state

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

trackcursorlight


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10821 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 7/29/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/pabhoj/cursor_light` --- ### 📝 Commits (10+) - [`58fd1b2`](https://github.com/microsoft/terminal/commit/58fd1b219ca3361539d9c02d32c8c143d1ef610a) highlight cursor - [`e7d8fdb`](https://github.com/microsoft/terminal/commit/e7d8fdb1543ea759d81a6d7f6c64f7328aad5817) safer access light - [`59cf2a6`](https://github.com/microsoft/terminal/commit/59cf2a6d4a21759fb1c5b88526a4b4f61eca0f8e) minor - [`3beeafa`](https://github.com/microsoft/terminal/commit/3beeafa427cb5834f588b4e66456f4eec925a31a) conflict - [`2af96f1`](https://github.com/microsoft/terminal/commit/2af96f18af7c56ec72cc3dcc77fbc38b9dec7b33) accidental removal - [`cf6e1b4`](https://github.com/microsoft/terminal/commit/cf6e1b4800ddfceb6a95167c591cd0d414d47c0c) Reduce diff - [`02dad2a`](https://github.com/microsoft/terminal/commit/02dad2a3480728397e3fcefb46f611f39a1d6c7b) incomplete cursor offscreen - [`ce2832c`](https://github.com/microsoft/terminal/commit/ce2832c75596889e861fff9fb5dea21ef5bda96f) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/cursor_light - [`b0e9bf3`](https://github.com/microsoft/terminal/commit/b0e9bf33f2de251f9aac61fc491d2bd58eaa4353) check if cursor off screen - [`0be9b2a`](https://github.com/microsoft/terminal/commit/0be9b2afecb34ff47cf784151c74b9360e84f80f) comments ### 📊 Changes **33 files changed** (+1484 additions, -914 deletions) <details> <summary>View changed files</summary> ➕ `.github/actions/spelling/README.md` (+15 -0) 📝 `.github/actions/spelling/advice.md` (+16 -18) 📝 `.github/actions/spelling/allow/allow.txt` (+39 -3) 📝 `.github/actions/spelling/allow/apis.txt` (+58 -2) 📝 `.github/actions/spelling/allow/math.txt` (+8 -0) 📝 `.github/actions/spelling/allow/microsoft.txt` (+12 -0) 📝 `.github/actions/spelling/allow/names.txt` (+12 -0) ➕ `.github/actions/spelling/candidate.patterns` (+523 -0) 📝 `.github/actions/spelling/excludes.txt` (+43 -5) 📝 `.github/actions/spelling/expect/alphabet.txt` (+0 -8) 📝 `.github/actions/spelling/expect/expect.txt` (+183 -735) 📝 `.github/actions/spelling/expect/web.txt` (+0 -11) ➕ `.github/actions/spelling/line_forbidden.patterns` (+62 -0) 📝 `.github/actions/spelling/patterns/patterns.txt` (+78 -8) 📝 `.github/actions/spelling/reject.txt` (+9 -19) 📝 `.github/workflows/spelling2.yml` (+123 -9) 📝 `doc/cascadia/profiles.schema.json` (+13 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+10 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+17 -1) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+3 -0) _...and 13 more files_ </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Adds a new keybinding, `HighlightCursor`, that darkens the entire screen except for the cursor location, allowing users to easily locate the cursor (see gif below) Pressing the keybinding highlights the cursor location and causes the light to follow the cursor as output/scrolling happens. Pressing the keybinding again returns the terminal to the normal state <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed ![trackcursorlight](https://user-images.githubusercontent.com/26824113/129802486-4c3be222-fab4-42f7-a8be-cae51a602766.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28248