[PR #10846] [MERGED] [settings-editor] Switch to function bindings instead of Converter objects #28257

Open
opened 2026-01-31 09:27:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10846
Author: @marcelwgn
Created: 8/1/2021
Status: Merged
Merged: 8/3/2021
Merged by: @undefined

Base: mainHead: dev/switch-to-converter-functions


📝 Commits (10+)

  • 3fee481 Add percentage sign to opacity slider values
  • 3ea94fb Switch to function binding instead of Converter objects
  • 9030618 Merge main
  • dfbaa36 Merge main
  • 2e2b9b5 Fix build errors and bugs and stuff
  • 4bd044b Fix missing bindbacks
  • 3e34e5d Fix formatting
  • 92e7fa0 Update src/cascadia/TerminalSettingsEditor/Converters.h
  • b2f50b8 Update src/cascadia/TerminalSettingsEditor/Appearances.xaml
  • 7e9c7af Update src/cascadia/TerminalSettingsEditor/Profiles.h

📊 Changes

37 files changed (+233 additions, -727 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Actions.xaml (+3 -4)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+13 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+5 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+7 -17)
src/cascadia/TerminalSettingsEditor/ColorLightenConverter.cpp (+0 -33)
src/cascadia/TerminalSettingsEditor/ColorLightenConverter.h (+0 -9)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml (+4 -9)
src/cascadia/TerminalSettingsEditor/ColorToBrushConverter.cpp (+0 -28)
src/cascadia/TerminalSettingsEditor/ColorToBrushConverter.h (+0 -30)
src/cascadia/TerminalSettingsEditor/ColorToHexConverter.cpp (+0 -30)
src/cascadia/TerminalSettingsEditor/ColorToHexConverter.h (+0 -30)
src/cascadia/TerminalSettingsEditor/Converters.cpp (+106 -0)
src/cascadia/TerminalSettingsEditor/Converters.h (+33 -0)
📝 src/cascadia/TerminalSettingsEditor/Converters.idl (+18 -59)
src/cascadia/TerminalSettingsEditor/FontWeightConverter.cpp (+0 -32)
src/cascadia/TerminalSettingsEditor/FontWeightConverter.h (+0 -30)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml (+1 -3)
src/cascadia/TerminalSettingsEditor/InvertedBooleanConverter.cpp (+0 -28)
src/cascadia/TerminalSettingsEditor/InvertedBooleanConverter.h (+0 -9)
src/cascadia/TerminalSettingsEditor/InvertedBooleanToVisibilityConverter.cpp (+0 -28)

...and 17 more files

📄 Description

Validation Steps Performed

Clicked around, validated that settings still behave the same (as far as
I can tell with my limited terminal configuration expertise)

Closes #10387


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10846 **Author:** [@marcelwgn](https://github.com/marcelwgn) **Created:** 8/1/2021 **Status:** ✅ Merged **Merged:** 8/3/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/switch-to-converter-functions` --- ### 📝 Commits (10+) - [`3fee481`](https://github.com/microsoft/terminal/commit/3fee48173a2ad149aeb2135f63a00b3422a42a43) Add percentage sign to opacity slider values - [`3ea94fb`](https://github.com/microsoft/terminal/commit/3ea94fbe4e4bb6efcc641f0d8783d5933e0e6818) Switch to function binding instead of Converter objects - [`9030618`](https://github.com/microsoft/terminal/commit/903061864a508156325ed78c367264561bcc0aea) Merge main - [`dfbaa36`](https://github.com/microsoft/terminal/commit/dfbaa3662a6a9b3f99e6e5cc71d02491c2421ead) Merge main - [`2e2b9b5`](https://github.com/microsoft/terminal/commit/2e2b9b57c5f40feeb05b1887a4e774b26328d63e) Fix build errors and bugs and stuff - [`4bd044b`](https://github.com/microsoft/terminal/commit/4bd044b4f7107f646c30d399a3c1ad58fb98e864) Fix missing bindbacks - [`3e34e5d`](https://github.com/microsoft/terminal/commit/3e34e5da09bcbbb27095b9ad68163abdf49e57d2) Fix formatting - [`92e7fa0`](https://github.com/microsoft/terminal/commit/92e7fa01d52cc13e1fc3bf37fb5077be0f4420f8) Update src/cascadia/TerminalSettingsEditor/Converters.h - [`b2f50b8`](https://github.com/microsoft/terminal/commit/b2f50b8e40978462a2cd8226eba5dff0204d133a) Update src/cascadia/TerminalSettingsEditor/Appearances.xaml - [`7e9c7af`](https://github.com/microsoft/terminal/commit/7e9c7afcde60f666990f6c4107aa87c3f68ccca5) Update src/cascadia/TerminalSettingsEditor/Profiles.h ### 📊 Changes **37 files changed** (+233 additions, -727 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Actions.xaml` (+3 -4) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+13 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+5 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+7 -17) ➖ `src/cascadia/TerminalSettingsEditor/ColorLightenConverter.cpp` (+0 -33) ➖ `src/cascadia/TerminalSettingsEditor/ColorLightenConverter.h` (+0 -9) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml` (+4 -9) ➖ `src/cascadia/TerminalSettingsEditor/ColorToBrushConverter.cpp` (+0 -28) ➖ `src/cascadia/TerminalSettingsEditor/ColorToBrushConverter.h` (+0 -30) ➖ `src/cascadia/TerminalSettingsEditor/ColorToHexConverter.cpp` (+0 -30) ➖ `src/cascadia/TerminalSettingsEditor/ColorToHexConverter.h` (+0 -30) ➕ `src/cascadia/TerminalSettingsEditor/Converters.cpp` (+106 -0) ➕ `src/cascadia/TerminalSettingsEditor/Converters.h` (+33 -0) 📝 `src/cascadia/TerminalSettingsEditor/Converters.idl` (+18 -59) ➖ `src/cascadia/TerminalSettingsEditor/FontWeightConverter.cpp` (+0 -32) ➖ `src/cascadia/TerminalSettingsEditor/FontWeightConverter.h` (+0 -30) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml` (+1 -3) ➖ `src/cascadia/TerminalSettingsEditor/InvertedBooleanConverter.cpp` (+0 -28) ➖ `src/cascadia/TerminalSettingsEditor/InvertedBooleanConverter.h` (+0 -9) ➖ `src/cascadia/TerminalSettingsEditor/InvertedBooleanToVisibilityConverter.cpp` (+0 -28) _...and 17 more files_ </details> ### 📄 Description ## Validation Steps Performed Clicked around, validated that settings still behave the same (as far as I can tell with my limited terminal configuration expertise) Closes #10387 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28257