[PR #10867] [MERGED] Fix SSE2 variant of TextColor::GetColor #28265

Open
opened 2026-01-31 09:27:23 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10867
Author: @lhecker
Created: 8/4/2021
Status: ✅ Merged
Merged: 8/4/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/fix-color-sse2


📝 Commits (1)

  • 3211923 Fix SSE2 variant of TextColor::GetColor

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 src/buffer/out/TextColor.cpp (+6 -3)

📄 Description

Shortly before adding the SSE2 variant I "improved" it by using
_mm_packs_epi32, but failed to test it again afterwards.

PR Checklist

Validation Steps Performed

  • printf "\e[mNORMAL \e[1mBOLD\n" results in correct bold white glyphs ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10867 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 8/4/2021 **Status:** ✅ Merged **Merged:** 8/4/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/fix-color-sse2` --- ### 📝 Commits (1) - [`3211923`](https://github.com/microsoft/terminal/commit/32119231519259350d5ae01fe32e3fcb0dd082c2) Fix SSE2 variant of TextColor::GetColor ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/buffer/out/TextColor.cpp` (+6 -3) </details> ### 📄 Description Shortly before adding the SSE2 variant I "improved" it by using `_mm_packs_epi32`, but failed to test it again afterwards. ## PR Checklist * [x] Closes #10866 * [x] I work here ## Validation Steps Performed * `printf "\e[mNORMAL \e[1mBOLD\n"` results in correct bold white glyphs ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:23 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28265