[PR #10901] [MERGED] Make the TerminalApi exception handler less garrulous #28285

Open
opened 2026-01-31 09:27:31 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10901
Author: @zadjii-msft
Created: 8/9/2021
Status: Merged
Merged: 8/9/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/10882-totally-garrulous-dude


📝 Commits (1)

📊 Changes

2 files changed (+27 additions, -18 deletions)

View changed files

📝 src/cascadia/TerminalCore/TerminalApi.cpp (+17 -17)
📝 src/inc/til.h (+10 -1)

📄 Description

Summary of the Pull Request

Apparently the exception handler in TerminalApi is far too talkative. We're apparently throwing in TerminalApi::CursorLineFeed way too often, and that's caused an internal bug to be filed on us.

This represents making the event less talkative, but doesn't actually fix the bug. It's just easier to get the OS bug cleared out quick this way.

References

  • MSFT:33310649

PR Checklist

  • Fixes the A portion of #10882, which closes MSFT:33310649
  • I work here
  • [n/a] Tests added/passed
  • [n/a] Requires documentation to be updated

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10901 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/9/2021 **Status:** ✅ Merged **Merged:** 8/9/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/10882-totally-garrulous-dude` --- ### 📝 Commits (1) - [`14a0b5f`](https://github.com/microsoft/terminal/commit/14a0b5f1e0590cc40d4ab4fa40e3670316b06c56) This should fix #10882.A ### 📊 Changes **2 files changed** (+27 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/TerminalApi.cpp` (+17 -17) 📝 `src/inc/til.h` (+10 -1) </details> ### 📄 Description ## Summary of the Pull Request Apparently the exception handler in TerminalApi is far too talkative. We're apparently throwing in `TerminalApi::CursorLineFeed` way too often, and that's caused an internal bug to be filed on us. This represents making the event less talkative, but doesn't actually fix the bug. It's just easier to get the OS bug cleared out quick this way. ## References * MSFT:33310649 ## PR Checklist * [x] Fixes the **A** portion of #10882, which closes MSFT:33310649 * [x] I work here * [n/a] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:31 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28285