starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10917] [MERGED] Fix layering of sc() keybindings with vk() ones #28295

New Issue
Open
opened 2026-01-31 09:27:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:36 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10917
Author: @lhecker
Created: 8/11/2021
Status: ✅ Merged
Merged: 8/12/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/10875-fix-action-map-layering

📝 Commits (4)

📊 Changes

8 files changed (+99 additions, -74 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+2 -0)
📝 src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp (+10 -11)
📝 src/cascadia/TerminalControl/KeyChord.cpp (+9 -3)
📝 src/cascadia/TerminalSettingsModel/ActionMap.cpp (+15 -33)
📝 src/cascadia/TerminalSettingsModel/ActionMap.h (+59 -5)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+1 -10)
📝 tools/OpenConsole.psm1 (+1 -10)
📝 tools/tests.xml (+2 -2)

📄 Description

The quake mode keybinding is bound to a scancode. This made it
impossible to override it with a vkey-based one like "win+`".
This commit fixes the issue by making sure that a KeyChord always has a vkey,
and leveraging this fact inside ActionMap, which now ignores the scan-code.

PR Checklist

Validation Steps Performed

  • quake mode and other keybinding still work ✔️
  • Repro settings from #10875 work correctly ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10917 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 8/11/2021 **Status:** ✅ Merged **Merged:** 8/12/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/10875-fix-action-map-layering` --- ### 📝 Commits (4) - [`6deaa87`](https://github.com/microsoft/terminal/commit/6deaa87233c9b4c3ddef10b5c7ea85b110324f7f) Fix layering of sc() keybindings with vk() ones - [`220213e`](https://github.com/microsoft/terminal/commit/220213ed716dfddf18ed9c9a53ff08777d9ed832) Fix formatting - [`4923655`](https://github.com/microsoft/terminal/commit/4923655385881cdabcabe80262c868072926e156) Fix build - [`3624100`](https://github.com/microsoft/terminal/commit/36241007e08d3ef2631aeafe01fff10cd52106ca) Fix x86 build ### 📊 Changes **8 files changed** (+99 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+2 -0) 📝 `src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp` (+10 -11) 📝 `src/cascadia/TerminalControl/KeyChord.cpp` (+9 -3) 📝 `src/cascadia/TerminalSettingsModel/ActionMap.cpp` (+15 -33) 📝 `src/cascadia/TerminalSettingsModel/ActionMap.h` (+59 -5) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+1 -10) 📝 `tools/OpenConsole.psm1` (+1 -10) 📝 `tools/tests.xml` (+2 -2) </details> ### 📄 Description The quake mode keybinding is bound to a scancode. This made it impossible to override it with a vkey-based one like "win+\`". This commit fixes the issue by making sure that a `KeyChord` always has a vkey, and leveraging this fact inside ActionMap, which now ignores the scan-code. ## PR Checklist * [x] Closes #10875 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * quake mode and other keybinding still work ✔️ * Repro settings from #10875 work correctly ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?