[PR #10907] [MERGED] Add logging, test for #10875 #28297

Open
opened 2026-01-31 09:27:36 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10907
Author: @zadjii-msft
Created: 8/9/2021
Status: Merged
Merged: 8/11/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/10875-tests-only


📝 Commits (6)

  • 5fc29b9 Add more logging that helped identify the source of the issue here
  • 57719b9 Well that would explain it.
  • 23e3306 LOL clrealy these tests were never run
  • 9e41999 Merge remote-tracking branch 'origin/main' into dev/migrie/b/10875-tests-only
  • 823d643 spel
  • 5c17526 Update src/cascadia/Remoting/Monarch.cpp

📊 Changes

5 files changed (+106 additions, -17 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp (+46 -4)
📝 src/cascadia/Remoting/Monarch.cpp (+27 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+11 -1)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+21 -11)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+1 -1)

📄 Description

Summary of the Pull Request

This isn't a fix for #10875, but it is logging that help identify the root cause here. The logging may additionally be helpful for some of the other issues we're seeing elsewhere in the repo, namely #10340.

@lhecker is actually working on the fix for #10875, so hopefully this test will help validate.

References

PR Checklist

  • Closes nothing
  • I work here
  • Tests added, and they absolutely fail, but they're localtests, so ¯\_(ツ)_/¯
  • [n/a] Requires documentation to be updated

details

While I was here, I noticed that KeyBindingsTests::KeyChords has been broken for some time now. So I fixed that too.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10907 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/9/2021 **Status:** ✅ Merged **Merged:** 8/11/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/10875-tests-only` --- ### 📝 Commits (6) - [`5fc29b9`](https://github.com/microsoft/terminal/commit/5fc29b914e2775f069f22f0b020aef4aded18f68) Add more logging that helped identify the source of the issue here - [`57719b9`](https://github.com/microsoft/terminal/commit/57719b90f091f6c1cb064193d6830632629f45e9) Well that would explain it. - [`23e3306`](https://github.com/microsoft/terminal/commit/23e3306bfbc266b679289fdaf54339f676dc4962) LOL clrealy these tests were never run - [`9e41999`](https://github.com/microsoft/terminal/commit/9e41999a57b642583dab7c204caa42bb11298d8c) Merge remote-tracking branch 'origin/main' into dev/migrie/b/10875-tests-only - [`823d643`](https://github.com/microsoft/terminal/commit/823d64390eb9b75068ebc99489853fc72b20322a) spel - [`5c17526`](https://github.com/microsoft/terminal/commit/5c17526cc59b42d9533649efbb2fe40a34bcb1b1) Update src/cascadia/Remoting/Monarch.cpp ### 📊 Changes **5 files changed** (+106 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp` (+46 -4) 📝 `src/cascadia/Remoting/Monarch.cpp` (+27 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+11 -1) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+21 -11) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+1 -1) </details> ### 📄 Description ## Summary of the Pull Request This isn't a fix for #10875, but it is logging that help identify the root cause here. The logging may additionally be helpful for some of the other issues we're seeing elsewhere in the repo, namely #10340. @lhecker is actually working on the fix for #10875, so hopefully this test will help validate. ## References * Regressed in #10666. * logging for #8888 ## PR Checklist * [x] Closes nothing * [x] I work here * [x] Tests added, and they absolutely fail, but they're localtests, so ¯\\\_(ツ)_/¯ * [n/a] Requires documentation to be updated ## details While I was here, I noticed that `KeyBindingsTests::KeyChords` has been broken for some time now. So I fixed that too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:36 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28297