[PR #10917] Fix layering of sc() keybindings with vk() ones #28300

Open
opened 2026-01-31 09:27:37 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/10917

State: closed
Merged: Yes


The quake mode keybinding is bound to a scancode. This made it
impossible to override it with a vkey-based one like "win+`".
This commit fixes the issue by making sure that a KeyChord always has a vkey,
and leveraging this fact inside ActionMap, which now ignores the scan-code.

PR Checklist

Validation Steps Performed

  • quake mode and other keybinding still work ✔️
  • Repro settings from #10875 work correctly ✔️
**Original Pull Request:** https://github.com/microsoft/terminal/pull/10917 **State:** closed **Merged:** Yes --- The quake mode keybinding is bound to a scancode. This made it impossible to override it with a vkey-based one like "win+\`". This commit fixes the issue by making sure that a `KeyChord` always has a vkey, and leveraging this fact inside ActionMap, which now ignores the scan-code. ## PR Checklist * [x] Closes #10875 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * quake mode and other keybinding still work ✔️ * Repro settings from #10875 work correctly ✔️
claunia added the pull-request label 2026-01-31 09:27:37 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28300