starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10927] [MERGED] GH10909 in order movement #28306

New Issue
Open
opened 2026-01-31 09:27:41 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:41 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10927
Author: @Rosefield
Created: 8/12/2021
Status: ✅ Merged
Merged: 8/16/2021
Merged by: @undefined

Base: main ← Head: feature/gh10909-in-order-movement

📝 Commits (4)

  • bfd982d GH10909 add in order movement. Refactor FocusPane/SwapPane to have a shared NavigateDirection function.
  • 7f19f31 Merge remote-tracking branch 'origin/main' into feature/gh10909-in-order-movement
  • 130a4b2 Fix comments about return values that now return bools.
  • d9f8b90 I guess I added a tab somehow?

📊 Changes

15 files changed (+310 additions, -156 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+5 -3)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+2 -2)
📝 src/cascadia/TerminalApp/AppCommandlineArgs.cpp (+11 -16)
📝 src/cascadia/TerminalApp/Pane.cpp (+216 -108)
📝 src/cascadia/TerminalApp/Pane.h (+16 -12)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+8 -3)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)
📝 src/cascadia/TerminalApp/TerminalTab.cpp (+19 -7)
📝 src/cascadia/TerminalApp/TerminalTab.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.cpp (+8 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+3 -1)
📝 src/cascadia/TerminalSettingsModel/JsonUtils.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw (+12 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+3 -1)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+4 -0)

📄 Description

Adds new in-order traversal for MoveFocus and SwapPane actions.
Refactors the Pane methods to share a NavigateDirection
implementation.

Closes #10909

A large amount of the churn here is just renaming some of the things for
directional movement to reflect that it might not always be based on the
focused pane. NextPane and PreviousPane are the functions that
actually select the next/previous pane respectively and are the core
component of this PR.

VALIDATION
Created multiple panes on a tab, and tried both forward and backwards
movements with move-focus and swap-pane.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10927 **Author:** [@Rosefield](https://github.com/Rosefield) **Created:** 8/12/2021 **Status:** ✅ Merged **Merged:** 8/16/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `feature/gh10909-in-order-movement` --- ### 📝 Commits (4) - [`bfd982d`](https://github.com/microsoft/terminal/commit/bfd982dcbe52f536dd35715b96432c660c990fc4) GH10909 add in order movement. Refactor FocusPane/SwapPane to have a shared NavigateDirection function. - [`7f19f31`](https://github.com/microsoft/terminal/commit/7f19f31dc45191c6663f4ba78ec4c7902f88fbd4) Merge remote-tracking branch 'origin/main' into feature/gh10909-in-order-movement - [`130a4b2`](https://github.com/microsoft/terminal/commit/130a4b272540fa6f475286cf551e01d464229f44) Fix comments about return values that now return bools. - [`d9f8b90`](https://github.com/microsoft/terminal/commit/d9f8b90f82114fe3315b1d85eff106a86c03433d) I guess I added a tab somehow? ### 📊 Changes **15 files changed** (+310 additions, -156 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+5 -3) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/AppCommandlineArgs.cpp` (+11 -16) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+216 -108) 📝 `src/cascadia/TerminalApp/Pane.h` (+16 -12) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+8 -3) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) 📝 `src/cascadia/TerminalApp/TerminalTab.cpp` (+19 -7) 📝 `src/cascadia/TerminalApp/TerminalTab.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.cpp` (+8 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+3 -1) 📝 `src/cascadia/TerminalSettingsModel/JsonUtils.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw` (+12 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+3 -1) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+4 -0) </details> ### 📄 Description Adds new in-order traversal for MoveFocus and SwapPane actions. Refactors the Pane methods to share a `NavigateDirection` implementation. Closes #10909 A large amount of the churn here is just renaming some of the things for directional movement to reflect that it might not always be based on the focused pane. `NextPane` and `PreviousPane` are the functions that actually select the next/previous pane respectively and are the core component of this PR. VALIDATION Created multiple panes on a tab, and tried both forward and backwards movements with move-focus and swap-pane. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?