[PR #10923] [MERGED] Remove std::deque from Renderer #28307

Open
opened 2026-01-31 09:27:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10923
Author: @lhecker
Created: 8/11/2021
Status: Merged
Merged: 8/24/2021
Merged by: @undefined

Base: mainHead: dev/lhecker/perf-renderer


📝 Commits (5)

  • 05ab6da Make Cluster constexpr
  • ec7cc19 Remove std::deque from Renderer
  • 47a08ae Address reviewer comments
  • 1b63fb1 Address reviewer comments
  • b71d3aa Merge remote-tracking branch 'origin/main' into dev/lhecker/perf-renderer

📊 Changes

10 files changed (+161 additions, -251 deletions)

View changed files

📝 src/host/ut_host/AliasTests.cpp (+0 -4)
📝 src/host/ut_host/TextBufferTests.cpp (+0 -7)
📝 src/host/ut_host/VtIoTests.cpp (+1 -0)
src/renderer/base/Cluster.cpp (+0 -61)
📝 src/renderer/base/lib/base.vcxproj (+0 -1)
📝 src/renderer/base/lib/base.vcxproj.filters (+0 -3)
📝 src/renderer/base/renderer.cpp (+112 -120)
📝 src/renderer/base/renderer.hpp (+14 -48)
📝 src/renderer/base/sources.inc (+0 -1)
📝 src/renderer/inc/Cluster.hpp (+34 -6)

📄 Description

This commit improves the renderer classes by:

  • reducing binary size by 4kB
  • improving performance by 5%
  • reducing code complexity

References

  • #10563 -- vtebench tracking issue

PR Checklist

  • I work here
  • Tests added/passed

Validation Steps Performed

  • Ran vtebench/termbench and noted ~5% perf. improvements

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10923 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 8/11/2021 **Status:** ✅ Merged **Merged:** 8/24/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/perf-renderer` --- ### 📝 Commits (5) - [`05ab6da`](https://github.com/microsoft/terminal/commit/05ab6da3642b8c029cca1aeacf1d8109d15421c9) Make Cluster constexpr - [`ec7cc19`](https://github.com/microsoft/terminal/commit/ec7cc190f001b9a09813bb562effb4ad9c4b2f04) Remove std::deque from Renderer - [`47a08ae`](https://github.com/microsoft/terminal/commit/47a08ae9bd85599af87cf226e089d94bbd43e2bd) Address reviewer comments - [`1b63fb1`](https://github.com/microsoft/terminal/commit/1b63fb1723bd421e3d6cba479384937c39000e4a) Address reviewer comments - [`b71d3aa`](https://github.com/microsoft/terminal/commit/b71d3aa0ff2bbf3a163be365d9874410308270dd) Merge remote-tracking branch 'origin/main' into dev/lhecker/perf-renderer ### 📊 Changes **10 files changed** (+161 additions, -251 deletions) <details> <summary>View changed files</summary> 📝 `src/host/ut_host/AliasTests.cpp` (+0 -4) 📝 `src/host/ut_host/TextBufferTests.cpp` (+0 -7) 📝 `src/host/ut_host/VtIoTests.cpp` (+1 -0) ➖ `src/renderer/base/Cluster.cpp` (+0 -61) 📝 `src/renderer/base/lib/base.vcxproj` (+0 -1) 📝 `src/renderer/base/lib/base.vcxproj.filters` (+0 -3) 📝 `src/renderer/base/renderer.cpp` (+112 -120) 📝 `src/renderer/base/renderer.hpp` (+14 -48) 📝 `src/renderer/base/sources.inc` (+0 -1) 📝 `src/renderer/inc/Cluster.hpp` (+34 -6) </details> ### 📄 Description This commit improves the renderer classes by: * reducing binary size by 4kB * improving performance by 5% * reducing code complexity ## References * #10563 -- vtebench tracking issue ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Ran vtebench/termbench and noted ~5% perf. improvements --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28307