starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10938] [MERGED] Tray Icon PR followup #28314

New Issue
Open
opened 2026-01-31 09:27:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:44 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10938
Author: @leonMSFT
Created: 8/12/2021
Status: ✅ Merged
Merged: 8/19/2021
Merged by: @undefined

Base: main ← Head: dev/lelian/notifyicon/followup

📝 Commits (4)

  • 2c2a880 accidentally kept monarch as defapp server, destroy tray icon if monarch
  • fdd14b3 move tray icon cleanup to somewhere that's not the destructor
  • b94e199 ensure we're not dead when we want to cleanup, move to the bg thread a little closer to the x-proc call
  • dd8d07e formatting

📊 Changes

4 files changed (+20 additions, -18 deletions)

View changed files

📝 src/cascadia/Remoting/WindowManager.cpp (+5 -2)
📝 src/cascadia/Remoting/WindowManager.h (+2 -2)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+11 -12)
📝 src/cascadia/WindowsTerminal/AppHost.h (+2 -2)

📄 Description

Some followups to #10368:

  • Accidentally reverted a defapp change where the Monarch should not by default register itself as a handoff server.
  • Destroy the tray icon if we're a monarch otherwise if we're a quake window we request the monarch to hide the icon.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10938 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 8/12/2021 **Status:** ✅ Merged **Merged:** 8/19/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lelian/notifyicon/followup` --- ### 📝 Commits (4) - [`2c2a880`](https://github.com/microsoft/terminal/commit/2c2a880fa7a0f9bd7b089eae3676e16863b84b87) accidentally kept monarch as defapp server, destroy tray icon if monarch - [`fdd14b3`](https://github.com/microsoft/terminal/commit/fdd14b37a9d018c639b54c5cc148f75ad04c75f4) move tray icon cleanup to somewhere that's not the destructor - [`b94e199`](https://github.com/microsoft/terminal/commit/b94e19996abf3c7752d8e0560fd9e25c57521c2b) ensure we're not dead when we want to cleanup, move to the bg thread a little closer to the x-proc call - [`dd8d07e`](https://github.com/microsoft/terminal/commit/dd8d07e2fa9df1a25668585aed69ac58a4f36f28) formatting ### 📊 Changes **4 files changed** (+20 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/Remoting/WindowManager.cpp` (+5 -2) 📝 `src/cascadia/Remoting/WindowManager.h` (+2 -2) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+11 -12) 📝 `src/cascadia/WindowsTerminal/AppHost.h` (+2 -2) </details> ### 📄 Description Some followups to #10368: - Accidentally reverted a defapp change where the Monarch should not by default register itself as a handoff server. - Destroy the tray icon if we're a monarch otherwise if we're a quake window we request the monarch to hide the icon. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28314
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?