starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #10966] [MERGED] Refactor u8u16 and u16u8 conversion functions #28327

New Issue
Open
opened 2026-01-31 09:27:49 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:49 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10966
Author: @german-one
Created: 8/17/2021
Status: ✅ Merged
Merged: 8/24/2021
Merged by: @undefined

Base: main ← Head: dev/steffen/u8u16nobuffer

📝 Commits (7)

  • ce3b5e0 Get rid of buffering in the partials handling of u8u16 and u16u8
  • f1642fc draft feedback
  • 2480a36 PR feedback lhecker
  • 70c2120 pass UT, make initialization style consistent
  • 283ae94 meaning of codePointLen 0 and 1 is no lead byte
  • 8f50cb0 use CATCH_RETURN
  • 912eaa8 add notes and source of the branchless UTF-8 converter

📊 Changes

2 files changed (+174 additions, -303 deletions)

View changed files

📝 .github/actions/spelling/allow/names.txt (+2 -0)
📝 src/inc/til/u8u16convert.h (+172 -303)

📄 Description

  • Perform the handling of partial code points in the u8u16 and u16u8
    conversion functions without preparation in a preliminary buffer.
  • Simplify partials handling in u8u16 (perf).
  • Declare the parameters for the incoming data as referenced
    string_views.
  • Simplify templatization.
  • Simplify exception handling.

We complete the partial codepoint in the 4-bytes long cache and convert
it separately. This makes the cache ready for capturing the next
partials before the remaining string is converted. This way, we neither
need to copy the whole string into a buffer which contains complete
codepoints, nor do we need to allocate an unnecessarily long buffer
which exists for the life time of the state class instance.

Finding and capturing of partials is performed in a more linear code
using the evaluation of the length of a code point.

The parameters for the incoming data are now explicitely declared to be
referenced string_views.

CATCH_RETURN is used to improve the readability of the code.

Validation Steps Performed

  • manually tested
  • unit tests passed

Closes #10946

Co-authored-by: Leonard Hecker lhecker@microsoft.com

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10966 **Author:** [@german-one](https://github.com/german-one) **Created:** 8/17/2021 **Status:** ✅ Merged **Merged:** 8/24/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/steffen/u8u16nobuffer` --- ### 📝 Commits (7) - [`ce3b5e0`](https://github.com/microsoft/terminal/commit/ce3b5e06794a8c66f6dac95940859d08c31520d0) Get rid of buffering in the partials handling of u8u16 and u16u8 - [`f1642fc`](https://github.com/microsoft/terminal/commit/f1642fcb510aea2b66ac0bcf6afacaccafaa3651) draft feedback - [`2480a36`](https://github.com/microsoft/terminal/commit/2480a365883c84a6af521ecb553b298b287a8ae0) PR feedback lhecker - [`70c2120`](https://github.com/microsoft/terminal/commit/70c212033e52aa811397649ca9969b8d27852488) pass UT, make initialization style consistent - [`283ae94`](https://github.com/microsoft/terminal/commit/283ae94b2a4377305a071f70dd2bac4ecb7a7a65) meaning of `codePointLen` 0 and 1 is no lead byte - [`8f50cb0`](https://github.com/microsoft/terminal/commit/8f50cb0686d3a3bb0849b2269d4a2072275567e4) use `CATCH_RETURN` - [`912eaa8`](https://github.com/microsoft/terminal/commit/912eaa82b3bff61a0b9cb9099f6c93711b2ed36c) add notes and source of the branchless UTF-8 converter ### 📊 Changes **2 files changed** (+174 additions, -303 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/names.txt` (+2 -0) 📝 `src/inc/til/u8u16convert.h` (+172 -303) </details> ### 📄 Description * Perform the handling of partial code points in the `u8u16` and `u16u8` conversion functions without preparation in a preliminary buffer. * Simplify partials handling in `u8u16` (perf). * Declare the parameters for the incoming data as referenced string_views. * Simplify templatization. * Simplify exception handling. We complete the partial codepoint in the 4-bytes long cache and convert it separately. This makes the cache ready for capturing the next partials before the remaining string is converted. This way, we neither need to copy the whole string into a buffer which contains complete codepoints, nor do we need to allocate an unnecessarily long buffer which exists for the life time of the state class instance. Finding and capturing of partials is performed in a more linear code using the evaluation of the length of a code point. The parameters for the incoming data are now explicitely declared to be referenced string_views. `CATCH_RETURN` is used to improve the readability of the code. ## Validation Steps Performed * manually tested * unit tests passed Closes #10946 Co-authored-by: Leonard Hecker <lhecker@microsoft.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28327
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?