[PR #10979] [MERGED] Don't scroll vertically on horizontal scroll motions #28334

Open
opened 2026-01-31 09:27:51 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/10979
Author: @zadjii-msft
Created: 8/18/2021
Status: Merged
Merged: 8/20/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/10329-horiz-scrolling


📝 Commits (2)

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalControl/TermControl.cpp (+6 -0)

📄 Description

Summary of the Pull Request

Pretty straightforward. Check if the scroll event is a horizontal movement. If it is, ignore it. We don't have a horizontal scrollbar.

References

  • obviously, revisit this if we ever do #1860

PR Checklist

Validation Steps Performed

  • scrolled ↑/↓ with slaptop trackpad: terminal scrolls.
  • scrolled ←/→ with slaptop trackpad: terminal doesn't scroll.
  • Scrolling slightly more vertically than horizontally still scrolls.
  • Scrolling slightly more horizontally than vertically doesn't scroll.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/10979 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 8/18/2021 **Status:** ✅ Merged **Merged:** 8/20/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/10329-horiz-scrolling` --- ### 📝 Commits (2) - [`3708d9f`](https://github.com/microsoft/terminal/commit/3708d9f64b72a566d1dde5361e4960ac9f899d10) This fixes #10329 - [`12a1ff6`](https://github.com/microsoft/terminal/commit/12a1ff606df75a8c5cd492b75c30df4095d8cb3f) Fode Cormat ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+6 -0) </details> ### 📄 Description ## Summary of the Pull Request Pretty straightforward. Check if the scroll event is a horizontal movement. If it is, ignore it. We don't have a horizontal scrollbar. ## References * obviously, revisit this if we ever do #1860 ## PR Checklist * [x] Closes #10329 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed * scrolled ↑/↓ with slaptop trackpad: terminal scrolls. * scrolled ←/→ with slaptop trackpad: terminal doesn't scroll. * Scrolling _slightly more vertically than horizontally_ still scrolls. * Scrolling _slightly more horizontally than vertically_ doesn't scroll. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:51 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28334