starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11028] [MERGED] Move PGO Helix pools #28359

New Issue
Open
opened 2026-01-31 09:27:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:27:59 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11028
Author: @miniksa
Created: 8/24/2021
Status: ✅ Merged
Merged: 8/25/2021
Merged by: @undefined

Base: main ← Head: dev/miniksa/pgo_helix

📝 Commits (10+)

  • a569702 attempt machine version test and change to artifact feed connection
  • 8b20d58 undo version override
  • fe565e6 bippity boppity boo
  • 3913e83 goof less
  • 4bd7ddb undo temporary testing stuff
  • 211e5fd closed and open helix queues
  • 74602f3 re-sprinkle helix access tokens
  • d17d024 conditionally append access token
  • 2b2c97c use correct method name
  • 8b51419 don't change settings.json

📊 Changes

7 files changed (+62 additions, -15 deletions)

View changed files

📝 build/Helix/OutputTestResults.ps1 (+2 -2)
📝 build/Helix/ProcessHelixFiles.ps1 (+22 -2)
📝 build/Helix/UpdateUnreliableTests.ps1 (+5 -4)
📝 build/pipelines/templates/build-console-pgo.yml (+1 -1)
📝 build/pipelines/templates/helix-processtestresults-job.yml (+2 -0)
📝 build/pipelines/templates/helix-runtests-job.yml (+15 -1)
📝 build/pipelines/templates/pgo-build-and-publish-nuget-job.yml (+15 -5)

📄 Description

Moves PGO runs to supported Helix pools. We need to match Microsoft-UI-XAML on which Helix pools we used for each type of activities.

PR Checklist

Validation Steps Performed

  • Run PGO build against this branch

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11028 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 8/24/2021 **Status:** ✅ Merged **Merged:** 8/25/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/pgo_helix` --- ### 📝 Commits (10+) - [`a569702`](https://github.com/microsoft/terminal/commit/a56970222ebf26c0106b0ec725abe421d09217b5) attempt machine version test and change to artifact feed connection - [`8b20d58`](https://github.com/microsoft/terminal/commit/8b20d5839c1681557a5c2a3d6ae6237bf114ded7) undo version override - [`fe565e6`](https://github.com/microsoft/terminal/commit/fe565e672c210c6369f306969dfc625cfd922e0c) bippity boppity boo - [`3913e83`](https://github.com/microsoft/terminal/commit/3913e8396c0fac8beb3d6b3293cfde4cd91906cd) goof less - [`4bd7ddb`](https://github.com/microsoft/terminal/commit/4bd7ddbb70fcac82e2c03dce771275fd23b83860) undo temporary testing stuff - [`211e5fd`](https://github.com/microsoft/terminal/commit/211e5fd83592dd1d72a0b5d42947bb60dbcc0657) closed and open helix queues - [`74602f3`](https://github.com/microsoft/terminal/commit/74602f34a37dacbadd2ec3d589a46f032c043380) re-sprinkle helix access tokens - [`d17d024`](https://github.com/microsoft/terminal/commit/d17d0247cf8050cebd0ab544b5babb302d96fab5) conditionally append access token - [`2b2c97c`](https://github.com/microsoft/terminal/commit/2b2c97c7c97b7039d7592c481cea06b3585f5c73) use correct method name - [`8b51419`](https://github.com/microsoft/terminal/commit/8b51419c3a3b24a52655b10b6562891767f74d46) don't change settings.json ### 📊 Changes **7 files changed** (+62 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `build/Helix/OutputTestResults.ps1` (+2 -2) 📝 `build/Helix/ProcessHelixFiles.ps1` (+22 -2) 📝 `build/Helix/UpdateUnreliableTests.ps1` (+5 -4) 📝 `build/pipelines/templates/build-console-pgo.yml` (+1 -1) 📝 `build/pipelines/templates/helix-processtestresults-job.yml` (+2 -0) 📝 `build/pipelines/templates/helix-runtests-job.yml` (+15 -1) 📝 `build/pipelines/templates/pgo-build-and-publish-nuget-job.yml` (+15 -5) </details> ### 📄 Description Moves PGO runs to supported Helix pools. We need to match Microsoft-UI-XAML on which Helix pools we used for each type of activities. ## PR Checklist * [x] Closes #10850 * [x] I work here * [x] If it builds, it sits. ## Validation Steps Performed * [x] Run PGO build against this branch --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:27:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28359
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?