[PR #11030] [MERGED] Teach CommandPalette to persist recent command lines #28368

Open
opened 2026-01-31 09:28:04 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11030
Author: @Don-Vito
Created: 8/24/2021
Status: Merged
Merged: 8/26/2021
Merged by: @undefined

Base: mainHead: 11026-recent-commands-state


📝 Commits (7)

  • 050e822 Teach CommandPalette to persist recent command lines
  • a16f6f6 Reduce race condition with another instance saving history
  • 16abe6b Improve readability and performance of command loading and storing
  • 7ed5fe2 Simplify the updateRecentCommands + make everything static
  • 048b6d6 Make updateRecentCommands atomic again
  • c67d35a Remove redundant qualifiers
  • 1ffc471 Optimize updateRecentCommands not to perform insert

📊 Changes

6 files changed (+102 additions, -18 deletions)

View changed files

📝 src/cascadia/TerminalApp/CommandPalette.cpp (+49 -11)
📝 src/cascadia/TerminalApp/CommandPalette.h (+4 -3)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.cpp (+42 -0)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.h (+3 -2)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.idl (+2 -0)
📝 src/cascadia/TerminalSettingsModel/JsonUtils.h (+2 -2)

📄 Description

Closes #11026


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11030 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 8/24/2021 **Status:** ✅ Merged **Merged:** 8/26/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `11026-recent-commands-state` --- ### 📝 Commits (7) - [`050e822`](https://github.com/microsoft/terminal/commit/050e8224385bf7fbdbc97350aa0569811a89959c) Teach CommandPalette to persist recent command lines - [`a16f6f6`](https://github.com/microsoft/terminal/commit/a16f6f659514564b1fea6fe22fa9482f666411ea) Reduce race condition with another instance saving history - [`16abe6b`](https://github.com/microsoft/terminal/commit/16abe6b4bf67af585464acb2c54c31e7dfc8b6c2) Improve readability and performance of command loading and storing - [`7ed5fe2`](https://github.com/microsoft/terminal/commit/7ed5fe23c8836b223235c288b99499e9b43036a1) Simplify the updateRecentCommands + make everything static - [`048b6d6`](https://github.com/microsoft/terminal/commit/048b6d65c54786d1432286381406b183d949f289) Make updateRecentCommands atomic again - [`c67d35a`](https://github.com/microsoft/terminal/commit/c67d35a2942ecf4ad3469c4b3a7e8d01c5119a05) Remove redundant qualifiers - [`1ffc471`](https://github.com/microsoft/terminal/commit/1ffc47126253592bc04e9ed20520ce1546439d9f) Optimize updateRecentCommands not to perform insert ### 📊 Changes **6 files changed** (+102 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CommandPalette.cpp` (+49 -11) 📝 `src/cascadia/TerminalApp/CommandPalette.h` (+4 -3) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.cpp` (+42 -0) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.h` (+3 -2) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.idl` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/JsonUtils.h` (+2 -2) </details> ### 📄 Description Closes #11026 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28368