[PR #11043] [MERGED] Provide the focused tab title in the Tray Icon's context menu #28378

Open
opened 2026-01-31 09:28:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11043
Author: @leonMSFT
Created: 8/26/2021
Status: Merged
Merged: 9/3/2021
Merged by: @undefined

Base: mainHead: dev/lelian/trayicon/moarinfo


📝 Commits (5)

📊 Changes

16 files changed (+167 additions, -91 deletions)

View changed files

📝 src/cascadia/Remoting/Monarch.cpp (+47 -59)
📝 src/cascadia/Remoting/Monarch.h (+63 -1)
📝 src/cascadia/Remoting/Monarch.idl (+8 -1)
📝 src/cascadia/Remoting/Peasant.h (+1 -0)
📝 src/cascadia/Remoting/Peasant.idl (+1 -0)
📝 src/cascadia/Remoting/WindowManager.cpp (+7 -11)
📝 src/cascadia/Remoting/WindowManager.h (+2 -1)
📝 src/cascadia/Remoting/WindowManager.idl (+2 -1)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+5 -0)
📝 src/cascadia/TerminalApp/AppLogic.h (+1 -0)
📝 src/cascadia/TerminalApp/AppLogic.idl (+1 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+1 -1)
📝 src/cascadia/UnitTests_Remoting/RemotingTests.cpp (+2 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+9 -4)
📝 src/cascadia/WindowsTerminal/TrayIcon.cpp (+15 -10)
📝 src/cascadia/WindowsTerminal/TrayIcon.h (+2 -2)

📄 Description

This PR adds a bit more information to each item in the Tray Icon's window selection submenu.
Currently it only shows the window ID and window name if given one.
Now each item will instead show{Window ID} : {Active Tab Title} [{Window Name}]

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11043 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 8/26/2021 **Status:** ✅ Merged **Merged:** 9/3/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lelian/trayicon/moarinfo` --- ### 📝 Commits (5) - [`3fe0d4c`](https://github.com/microsoft/terminal/commit/3fe0d4c0103cf7b680ed5982379ebdf70ee9b6d6) plumb the title through the house - [`dc5f6a0`](https://github.com/microsoft/terminal/commit/dc5f6a0a1d3ee02aa687936df215c778a88f9190) pr comments - [`ac06a68`](https://github.com/microsoft/terminal/commit/ac06a68e9f138fbfa71b0b137d66d84dfd653b34) add method to test class - [`73c8e51`](https://github.com/microsoft/terminal/commit/73c8e512db879b84d862a37e6b8de480bbed1dcd) pr comments - [`973d58d`](https://github.com/microsoft/terminal/commit/973d58dacb2e63f68fb863bbeab673df4ebf7fa1) a bit more ### 📊 Changes **16 files changed** (+167 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/Remoting/Monarch.cpp` (+47 -59) 📝 `src/cascadia/Remoting/Monarch.h` (+63 -1) 📝 `src/cascadia/Remoting/Monarch.idl` (+8 -1) 📝 `src/cascadia/Remoting/Peasant.h` (+1 -0) 📝 `src/cascadia/Remoting/Peasant.idl` (+1 -0) 📝 `src/cascadia/Remoting/WindowManager.cpp` (+7 -11) 📝 `src/cascadia/Remoting/WindowManager.h` (+2 -1) 📝 `src/cascadia/Remoting/WindowManager.idl` (+2 -1) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+5 -0) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+1 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+1 -1) 📝 `src/cascadia/UnitTests_Remoting/RemotingTests.cpp` (+2 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+9 -4) 📝 `src/cascadia/WindowsTerminal/TrayIcon.cpp` (+15 -10) 📝 `src/cascadia/WindowsTerminal/TrayIcon.h` (+2 -2) </details> ### 📄 Description This PR adds a bit more information to each item in the Tray Icon's window selection submenu. Currently it only shows the window ID and window name if given one. Now each item will instead show`{Window ID} : {Active Tab Title} [{Window Name}]` ![image](https://user-images.githubusercontent.com/57155886/130883675-7a76e674-2429-4b26-b869-2455a9e4b4f6.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28378