starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11086] [MERGED] Add an openSystemMenu keybinding #28405

New Issue
Open
opened 2026-01-31 09:28:19 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:28:19 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11086
Author: @PankajBhojwani
Created: 8/30/2021
Status: ✅ Merged
Merged: 9/10/2021
Merged by: @undefined

Base: main ← Head: dev/pabhoj/alt_space

📝 Commits (4)

📊 Changes

18 files changed (+95 additions, -73 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+1 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+7 -0)
📝 src/cascadia/TerminalApp/AppLogic.h (+1 -0)
📝 src/cascadia/TerminalApp/AppLogic.idl (+1 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -0)
📝 src/cascadia/TerminalApp/TerminalPage.idl (+1 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+0 -18)
📝 src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/AllShortcutActions.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw (+3 -0)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+1 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+7 -0)
📝 src/cascadia/WindowsTerminal/AppHost.h (+3 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.cpp (+58 -0)
📝 src/cascadia/WindowsTerminal/IslandWindow.h (+2 -0)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+1 -45)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.h (+0 -2)
📝 src/cascadia/WindowsTerminal/main.cpp (+5 -8)

📄 Description

Summary of the Pull Request

Basically undoes #10988 in favour of implementing it as described in #11018

PR Checklist

Validation Steps Performed

  • alt+space opens the system menu by default
  • when alt+space is bound, the keys do not get send to terminal
  • right-click on the tab bar didn't break (still opens system menu at the location of the cursor)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11086 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 8/30/2021 **Status:** ✅ Merged **Merged:** 9/10/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/alt_space` --- ### 📝 Commits (4) - [`b466c6c`](https://github.com/microsoft/terminal/commit/b466c6cdaa64e625bf3f40eaf1cea144a22352a1) open system menu keybinding - [`3e21b94`](https://github.com/microsoft/terminal/commit/3e21b94ac1970466e9a2f7061dd15922293b2b81) conflict - [`5dc95ef`](https://github.com/microsoft/terminal/commit/5dc95ef07bc82bf59c457c943705c879ec12f8ff) conflict - [`a1b8154`](https://github.com/microsoft/terminal/commit/a1b815451f56406e8e01b02e0ad61a6d76168e84) schema ### 📊 Changes **18 files changed** (+95 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+1 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+7 -0) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+1 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.idl` (+1 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+0 -18) 📝 `src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/AllShortcutActions.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw` (+3 -0) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+1 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+7 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.h` (+3 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.cpp` (+58 -0) 📝 `src/cascadia/WindowsTerminal/IslandWindow.h` (+2 -0) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+1 -45) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.h` (+0 -2) 📝 `src/cascadia/WindowsTerminal/main.cpp` (+5 -8) </details> ### 📄 Description ## Summary of the Pull Request Basically undoes #10988 in favour of implementing it as described in #11018 ## PR Checklist * [x] Closes #11018 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [X] Tests added/passed * [X] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [X] Schema updated. * [x] I work here ## Validation Steps Performed - alt+space opens the system menu by default - when alt+space is bound, the keys do not get send to terminal - right-click on the tab bar didn't break (still opens system menu at the location of the cursor) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:19 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28405
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?