starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11139] [MERGED] Teach info bars to be dismissed permanently #28434

New Issue
Open
opened 2026-01-31 09:28:30 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:28:30 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11139
Author: @Don-Vito
Created: 9/4/2021
Status: ✅ Merged
Merged: 9/10/2021
Merged by: @undefined

Base: main ← Head: 10798-introduce-dismissable-messages

📝 Commits (4)

  • ccc1c6e Teach info bars to be dismissed permanently
  • 05b0916 Revert enum mappings change
  • e4994db Merge remote-tracking branch 'upstream/main' into 10798-introduce-dismissable-messages
  • d546ca5 Fix language resources

📊 Changes

7 files changed (+161 additions, -12 deletions)

View changed files

📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+6 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+103 -3)
📝 src/cascadia/TerminalApp/TerminalPage.h (+7 -1)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+27 -7)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.h (+2 -1)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.idl (+8 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+8 -0)

📄 Description

Summary of the Pull Request

  • Introduces info bar shown upon session failure,
    that guides the user how to configure termination behavior
    • Allows this info bar to be dismissed permanently (choice stored in state)
  • Allows "keyboard service" info bar to be dismissed permanently

PR Checklist

Detailed Description of the Pull Request / Additional comments

UI:

  • Introduce an additional info bar for "close on exit" configuration tip
    • Stack this bar after "keyboard service" bar
  • Add "Don't show again" button to both bars

Dismiss Permanently:

  • Introduce a set of "dismissed messages" to the Application State
  • Add verification the message is not dismissed before showing an info bar
  • "Don't show again" persists the choice under "dismissed messages"

Wiring the Info Bar:

  • Register TerminalPage on TermControl's ConnectionStateChanged event
  • Once event is triggered check whether the state is failure
  • If so and the message was not dismissed permanently, show the info bar

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11139 **Author:** [@Don-Vito](https://github.com/Don-Vito) **Created:** 9/4/2021 **Status:** ✅ Merged **Merged:** 9/10/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `10798-introduce-dismissable-messages` --- ### 📝 Commits (4) - [`ccc1c6e`](https://github.com/microsoft/terminal/commit/ccc1c6e2b9c2ec71c422c74884153b35a7778a35) Teach info bars to be dismissed permanently - [`05b0916`](https://github.com/microsoft/terminal/commit/05b0916466ef5739a41557ff6d8a844300803439) Revert enum mappings change - [`e4994db`](https://github.com/microsoft/terminal/commit/e4994dbbbcddce7d2816916e969665cc8a1fddd1) Merge remote-tracking branch 'upstream/main' into 10798-introduce-dismissable-messages - [`d546ca5`](https://github.com/microsoft/terminal/commit/d546ca547aa452bfd0497b4235a75912cb660742) Fix language resources ### 📊 Changes **7 files changed** (+161 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+6 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+103 -3) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+7 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+27 -7) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.h` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.idl` (+8 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+8 -0) </details> ### 📄 Description ## Summary of the Pull Request * Introduces info bar shown upon session failure, that guides the user how to configure termination behavior * Allows this info bar to be dismissed permanently (choice stored in state) * Allows "keyboard service" info bar to be dismissed permanently ## PR Checklist * [x] Closes #10798, closes #8699 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've discussed this with core contributors already. ## Detailed Description of the Pull Request / Additional comments UI: * Introduce an additional info bar for "close on exit" configuration tip * Stack this bar after "keyboard service" bar * Add "Don't show again" button to both bars Dismiss Permanently: * Introduce a set of "dismissed messages" to the Application State * Add verification the message is not dismissed before showing an info bar * "Don't show again" persists the choice under "dismissed messages" Wiring the Info Bar: * Register `TerminalPage` on `TermControl`'s `ConnectionStateChanged` event * Once event is triggered check whether the state is failure * If so and the message was not dismissed permanently, show the info bar --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:30 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28434
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?