starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11143] [MERGED] Add the ability to quit all terminal instances #28438

New Issue
Open
opened 2026-01-31 09:28:31 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:28:31 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11143
Author: @Rosefield
Created: 9/4/2021
Status: ✅ Merged
Merged: 9/9/2021
Merged by: @undefined

Base: main ← Head: feature/gh11081-add-quit-action

📝 Commits (6)

  • bd4a3b5 Add the ability to quit all terminal instances
  • aa74d9f add to schema
  • 79c092d Make sure the tests build too.
  • 5072358 tabs vs spaces teh endless debate. Maybe the editorconfig can include resw files.
  • d66a05c Fix unfinished comment, add tracking number for todo.
  • cecf5af Merge remote-tracking branch 'origin/main' into feature/gh11081-add-quit-action

📊 Changes

25 files changed (+227 additions, -6 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+1 -0)
📝 src/cascadia/Remoting/Monarch.cpp (+30 -0)
📝 src/cascadia/Remoting/Monarch.h (+4 -0)
📝 src/cascadia/Remoting/Monarch.idl (+1 -0)
📝 src/cascadia/Remoting/Peasant.cpp (+32 -0)
📝 src/cascadia/Remoting/Peasant.h (+4 -0)
📝 src/cascadia/Remoting/Peasant.idl (+4 -0)
📝 src/cascadia/Remoting/WindowManager.cpp (+14 -0)
📝 src/cascadia/Remoting/WindowManager.h (+2 -0)
📝 src/cascadia/Remoting/WindowManager.idl (+2 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+8 -1)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+9 -1)
📝 src/cascadia/TerminalApp/AppLogic.h (+3 -0)
📝 src/cascadia/TerminalApp/AppLogic.idl (+3 -0)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+12 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+41 -2)
📝 src/cascadia/TerminalApp/TerminalPage.h (+4 -1)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+5 -0)
📝 src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/AllShortcutActions.h (+2 -1)

...and 5 more files

📄 Description

Add the ability to quit all terminal instances. Doing this separately from the window layout saving ones to lessen the number of 1k+ line monsters I make y'all review.

References

#11083

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Warn the user before they do so to give a chance to cancel
  • Percolate a QuitAll event up to the monarch who then directs each peasant to clsoe.
  • Leave a window-layout-saving-sized hole to add that feature on top

Validation Steps Performed

  • quit with one window (from the monarch)
  • quit from the monarch with multiple windows
  • quit from a peasant
  • cancel the quit dialog

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11143 **Author:** [@Rosefield](https://github.com/Rosefield) **Created:** 9/4/2021 **Status:** ✅ Merged **Merged:** 9/9/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `feature/gh11081-add-quit-action` --- ### 📝 Commits (6) - [`bd4a3b5`](https://github.com/microsoft/terminal/commit/bd4a3b56b34344a1a2542cb4430f32ff6eeb9abf) Add the ability to quit all terminal instances - [`aa74d9f`](https://github.com/microsoft/terminal/commit/aa74d9f2d55a73bb88138ce27326973307022f37) add to schema - [`79c092d`](https://github.com/microsoft/terminal/commit/79c092d0cd334d4eb2706216c8c1991834123d55) Make sure the tests build too. - [`5072358`](https://github.com/microsoft/terminal/commit/507235877dbda773b8f80789429f78afd5cf2c9f) tabs vs spaces teh endless debate. Maybe the editorconfig can include resw files. - [`d66a05c`](https://github.com/microsoft/terminal/commit/d66a05c24ff8eac5bc603926b6e58b18d293459f) Fix unfinished comment, add tracking number for todo. - [`cecf5af`](https://github.com/microsoft/terminal/commit/cecf5afebaaa7e38f52366e56740371a4aae7569) Merge remote-tracking branch 'origin/main' into feature/gh11081-add-quit-action ### 📊 Changes **25 files changed** (+227 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+1 -0) 📝 `src/cascadia/Remoting/Monarch.cpp` (+30 -0) 📝 `src/cascadia/Remoting/Monarch.h` (+4 -0) 📝 `src/cascadia/Remoting/Monarch.idl` (+1 -0) 📝 `src/cascadia/Remoting/Peasant.cpp` (+32 -0) 📝 `src/cascadia/Remoting/Peasant.h` (+4 -0) 📝 `src/cascadia/Remoting/Peasant.idl` (+4 -0) 📝 `src/cascadia/Remoting/WindowManager.cpp` (+14 -0) 📝 `src/cascadia/Remoting/WindowManager.h` (+2 -0) 📝 `src/cascadia/Remoting/WindowManager.idl` (+2 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+8 -1) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+9 -1) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+3 -0) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+3 -0) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+12 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+41 -2) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+4 -1) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+5 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/AllShortcutActions.h` (+2 -1) _...and 5 more files_ </details> ### 📄 Description Add the ability to quit all terminal instances. Doing this separately from the window layout saving ones to lessen the number of 1k+ line monsters I make y'all review. ## References #11083 ## PR Checklist * [x] Closes #11081 * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [x] Schema updated. ## Detailed Description of the Pull Request / Additional comments - Warn the user before they do so to give a chance to cancel - Percolate a QuitAll event up to the monarch who then directs each peasant to clsoe. - Leave a window-layout-saving-sized hole to add that feature on top ## Validation Steps Performed - quit with one window (from the monarch) - quit from the monarch with multiple windows - quit from a peasant - cancel the quit dialog ![image](https://user-images.githubusercontent.com/6185249/132105775-3310f614-ce55-4454-9718-ef5c0d39fbd2.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28438
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?