[PR #11219] [MERGED] Replace TrayIcon with NotificationIcon #28456

Open
opened 2026-01-31 09:28:38 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11219
Author: @leonMSFT
Created: 9/13/2021
Status: ✅ Merged
Merged: 9/14/2021
Merged by: @undefined

Base: main ← Head: dev/lelian/notifyicon/rename


📝 Commits (4)

📊 Changes

36 files changed (+263 additions, -266 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+4 -4)
📝 src/cascadia/Remoting/Monarch.cpp (+2 -2)
📝 src/cascadia/Remoting/Monarch.h (+2 -2)
📝 src/cascadia/Remoting/Monarch.idl (+2 -2)
📝 src/cascadia/Remoting/Peasant.cpp (+6 -6)
📝 src/cascadia/Remoting/Peasant.h (+4 -4)
📝 src/cascadia/Remoting/Peasant.idl (+4 -4)
📝 src/cascadia/Remoting/WindowManager.cpp (+9 -9)
📝 src/cascadia/Remoting/WindowManager.h (+4 -4)
📝 src/cascadia/Remoting/WindowManager.idl (+4 -4)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+6 -6)
📝 src/cascadia/TerminalApp/AppLogic.h (+2 -2)
📝 src/cascadia/TerminalApp/AppLogic.idl (+2 -2)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.h (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.idl (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml (+8 -8)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+5 -5)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp (+8 -8)

...and 16 more files

📄 Description

This PR simply replaces all uses of "TrayIcon" and "Tray" with "NotificationIcon" and "NotificationArea" to be more accurate. Originally I kinda wanted to only replace all occurrences of it in settings and user facing things, but I figured I might as well make it consistent throughout all of our code.

Closes #11101.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11219 **Author:** [@leonMSFT](https://github.com/leonMSFT) **Created:** 9/13/2021 **Status:** ✅ Merged **Merged:** 9/14/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lelian/notifyicon/rename` --- ### 📝 Commits (4) - [`604406d`](https://github.com/microsoft/terminal/commit/604406dadde47d709f6975ba055d4396bab6c74b) did i get em all? - [`c5b4f94`](https://github.com/microsoft/terminal/commit/c5b4f94a67f0980670cdbd99a79b586713e68df2) a few stragglers - [`7a39244`](https://github.com/microsoft/terminal/commit/7a392443131b27ddb44f0a22094c2f6d51940323) reverse time - [`243efa1`](https://github.com/microsoft/terminal/commit/243efa1be37a3155cd2f8bb003c9c8c49808df4e) formatting ### 📊 Changes **36 files changed** (+263 additions, -266 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+4 -4) 📝 `src/cascadia/Remoting/Monarch.cpp` (+2 -2) 📝 `src/cascadia/Remoting/Monarch.h` (+2 -2) 📝 `src/cascadia/Remoting/Monarch.idl` (+2 -2) 📝 `src/cascadia/Remoting/Peasant.cpp` (+6 -6) 📝 `src/cascadia/Remoting/Peasant.h` (+4 -4) 📝 `src/cascadia/Remoting/Peasant.idl` (+4 -4) 📝 `src/cascadia/Remoting/WindowManager.cpp` (+9 -9) 📝 `src/cascadia/Remoting/WindowManager.h` (+4 -4) 📝 `src/cascadia/Remoting/WindowManager.idl` (+4 -4) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+6 -6) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+2 -2) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+2 -2) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.idl` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml` (+8 -8) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+5 -5) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp` (+8 -8) _...and 16 more files_ </details> ### 📄 Description This PR simply replaces all uses of "TrayIcon" and "Tray" with "NotificationIcon" and "NotificationArea" to be more accurate. Originally I kinda wanted to only replace all occurrences of it in settings and user facing things, but I figured I might as well make it consistent throughout all of our code. Closes #11101. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:38 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28456