[PR #11242] [MERGED] VsSetup: Replace com_ptr params with raw pointers, clean up code #28464

Open
opened 2026-01-31 09:28:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11242
Author: @DHowett
Created: 9/15/2021
Status: Merged
Merged: 9/16/2021
Merged by: @undefined

Base: mainHead: dev/duhowett/vssetup-followup


📝 Commits (2)

  • 2a4ede3 VsSetup: Replace com_ptr params with raw pointers, clean up code
  • b8ecf77 Fix clang-tidy issues & Pass VsSetupInstance by ref

📊 Changes

8 files changed (+80 additions, -97 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/BaseVisualStudioGenerator.cpp (+4 -6)
📝 src/cascadia/TerminalSettingsModel/BaseVisualStudioGenerator.h (+9 -10)
📝 src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.h (+5 -8)
📝 src/cascadia/TerminalSettingsModel/VsDevShellGenerator.cpp (+2 -4)
📝 src/cascadia/TerminalSettingsModel/VsDevShellGenerator.h (+5 -8)
📝 src/cascadia/TerminalSettingsModel/VsSetupConfiguration.cpp (+12 -12)
📝 src/cascadia/TerminalSettingsModel/VsSetupConfiguration.h (+41 -47)

📄 Description

This commit aligns the COM-consuming code in VsSetupInstance with best
practices such as passing COM pointers by pointer when they do not need
to be owning references and not using const on members, as well as
cleans up some dead code.

Leonard contributed clang-tidy fixes and some reference passing
changes.

Co-authored-by: Leonard Hecker lhecker@microsoft.com


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11242 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 9/15/2021 **Status:** ✅ Merged **Merged:** 9/16/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/vssetup-followup` --- ### 📝 Commits (2) - [`2a4ede3`](https://github.com/microsoft/terminal/commit/2a4ede32cf2649e51b6b4d681e41661f3f457f53) VsSetup: Replace com_ptr params with raw pointers, clean up code - [`b8ecf77`](https://github.com/microsoft/terminal/commit/b8ecf773af01a0fe3979788589742986319f110d) Fix clang-tidy issues & Pass VsSetupInstance by ref ### 📊 Changes **8 files changed** (+80 additions, -97 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/BaseVisualStudioGenerator.cpp` (+4 -6) 📝 `src/cascadia/TerminalSettingsModel/BaseVisualStudioGenerator.h` (+9 -10) 📝 `src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.h` (+5 -8) 📝 `src/cascadia/TerminalSettingsModel/VsDevShellGenerator.cpp` (+2 -4) 📝 `src/cascadia/TerminalSettingsModel/VsDevShellGenerator.h` (+5 -8) 📝 `src/cascadia/TerminalSettingsModel/VsSetupConfiguration.cpp` (+12 -12) 📝 `src/cascadia/TerminalSettingsModel/VsSetupConfiguration.h` (+41 -47) </details> ### 📄 Description This commit aligns the COM-consuming code in VsSetupInstance with best practices such as passing COM pointers by pointer when they do not need to be owning references and not using `const` on members, as well as cleans up some dead code. Leonard contributed clang-tidy fixes and some reference passing changes. Co-authored-by: Leonard Hecker <lhecker@microsoft.com> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28464