starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11314] [MERGED] Properly escape constructed wt command-lines #28495

New Issue
Open
opened 2026-01-31 09:28:55 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:28:55 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11314
Author: @ianjoneill
Created: 9/23/2021
Status: ✅ Merged
Merged: 9/24/2021
Merged by: @undefined

Base: main ← Head: f-escape-constructed-wt-command-lines

📝 Commits (5)

  • b636864 Properly escape constructed wt command-lines
  • 1eb8167 Address review comment
  • 007be88 Merge remote-tracking branch 'upstream/main' into f-escape-constructed-wt-command-lines
  • 85c8794 Merge remote-tracking branch 'upstream/main' into f-escape-constructed-wt-command-lines
  • 5ac40c2 Address review comment

📊 Changes

4 files changed (+63 additions, -11 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/CommandTests.cpp (+20 -1)
📝 src/cascadia/ShellExtension/OpenTerminalHere.cpp (+2 -4)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.cpp (+4 -6)
📝 src/cascadia/WinRTUtils/inc/WtExeUtils.h (+37 -0)

📄 Description

Ensures that command-lines constructed to invoke wt are escaped properly.

PR Checklist

Detailed Description of the Pull Request / Additional comments

This was broken in two places - when constructing the command-line in the shell extension and in NewTerminalArgs::ToCommandline().

Both places now invoke a shared method to escape the command-line arguments that require it.

Validation Steps Performed

Added a test and additionally:

  • Invoked the shell extension from D:\Downloads\With;Semicolon.
  • Added a newWindow action to settings.json as below and ensured the new window opened without erroring. 
    {
  "command": 
  {
    "action": "newWindow",
    "tabTitle": "\";foo\\"
  },
  "keys": "ctrl+shift+s"
}

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11314 **Author:** [@ianjoneill](https://github.com/ianjoneill) **Created:** 9/23/2021 **Status:** ✅ Merged **Merged:** 9/24/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `f-escape-constructed-wt-command-lines` --- ### 📝 Commits (5) - [`b636864`](https://github.com/microsoft/terminal/commit/b6368642d462fead2f668852e06433c0b96052c9) Properly escape constructed `wt` command-lines - [`1eb8167`](https://github.com/microsoft/terminal/commit/1eb816745d400ec8e8682b8621f332feb0a1e067) Address review comment - [`007be88`](https://github.com/microsoft/terminal/commit/007be885c596d723037ceaf1898b46aa72d331b9) Merge remote-tracking branch 'upstream/main' into f-escape-constructed-wt-command-lines - [`85c8794`](https://github.com/microsoft/terminal/commit/85c879471a70a994ca25443ab8b7bcb08a19556a) Merge remote-tracking branch 'upstream/main' into f-escape-constructed-wt-command-lines - [`5ac40c2`](https://github.com/microsoft/terminal/commit/5ac40c2da2a22d6e5824a36fb9cca9e24a77513c) Address review comment ### 📊 Changes **4 files changed** (+63 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/CommandTests.cpp` (+20 -1) 📝 `src/cascadia/ShellExtension/OpenTerminalHere.cpp` (+2 -4) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.cpp` (+4 -6) 📝 `src/cascadia/WinRTUtils/inc/WtExeUtils.h` (+37 -0) </details> ### 📄 Description Ensures that command-lines constructed to invoke `wt` are escaped properly. ## PR Checklist * [x] Closes #11273 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Tests added/passed ## Detailed Description of the Pull Request / Additional comments This was broken in two places - when constructing the command-line in the shell extension and in `NewTerminalArgs::ToCommandline()`. Both places now invoke a shared method to escape the command-line arguments that require it. ## Validation Steps Performed Added a test and additionally: * Invoked the shell extension from `D:\Downloads\With;Semicolon`. * Added a `newWindow` action to `settings.json` as below and ensured the new window opened without erroring. ```json { "command": { "action": "newWindow", "tabTitle": "\";foo\\" }, "keys": "ctrl+shift+s" } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:28:55 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28495
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?