[PR #11364] [MERGED] Add automation names to some controls that were missing them #28524

Open
opened 2026-01-31 09:29:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11364
Author: @zadjii-msft
Created: 9/28/2021
Status: Merged
Merged: 9/29/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/11155-accessibility-nits


📝 Commits (3)

📊 Changes

4 files changed (+50 additions, -9 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+6 -3)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+4 -2)
📝 src/cascadia/TerminalSettingsEditor/Profiles.xaml (+8 -4)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+32 -0)

📄 Description

All these controls didn't have Names assigned, and Accessibility Insights doesn't like that. Their parents did, but the actual focusable elements themselves didn't. So I've just taken the nearby headers for these things and slapped them in as the Automation names for these controls.

I verified that each of these automated tests in Accessibility Insights pass again.

  • Will do the thing to #11155 but we need confirmation before that can be closed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11364 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/28/2021 **Status:** ✅ Merged **Merged:** 9/29/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11155-accessibility-nits` --- ### 📝 Commits (3) - [`d27a41d`](https://github.com/microsoft/terminal/commit/d27a41dfd8fd7429d1e5c04ede4d45fd0f10dceb) This fixes the launch size - [`cab5bf0`](https://github.com/microsoft/terminal/commit/cab5bf0a3cf4d4778f81bf0ce3d8572578afb4e2) this fixes the rest of #11155 - [`cb4f1cd`](https://github.com/microsoft/terminal/commit/cb4f1cd362dfd21eb33dd683427fc554e6490166) runformat ### 📊 Changes **4 files changed** (+50 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+6 -3) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+4 -2) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.xaml` (+8 -4) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+32 -0) </details> ### 📄 Description All these controls didn't have `Name`s assigned, and Accessibility Insights doesn't like that. Their parents did, but the actual focusable elements themselves didn't. So I've just taken the nearby headers for these things and slapped them in as the Automation names for these controls. I verified that each of these automated tests in Accessibility Insights pass again. * Will do the thing to #11155 but we need confirmation before that can be closed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28524