[PR #11372] [MERGED] When enabling opacity on win10, automatically enable acrylic #28525

Open
opened 2026-01-31 09:29:05 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11372
Author: @zadjii-msft
Created: 9/29/2021
Status: Merged
Merged: 10/7/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/11285-opacity-on-win10


📝 Commits (10+)

  • 93831f1 When enabling opacity on win10, automatically enable acrylic
  • 0ee8817 Merge remote-tracking branch 'origin/main' into dev/migrie/b/11285-opacity-on-win10
  • 0af9c4d Merge remote-tracking branch 'origin/main' into dev/migrie/b/11285-opacity-on-win10
  • 7fd3fb7 Merge remote-tracking branch 'origin/main' into dev/migrie/b/11285-opacity-on-win10
  • 2805557 these were pr nits
  • 2e509d3 this does the auto-opacity thing, but does it on all versions
  • 3347d9c fix the sui for @carlos-zamora
  • 2ea7f4b sometimes I don't always buid the code
  • a3cbc30 yea of course this is it'
  • 0b6d428 this should fix the tests

📊 Changes

6 files changed (+76 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+35 -0)
📝 src/cascadia/TerminalControl/ControlCore.h (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+16 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.h (+14 -0)
📝 src/cascadia/UnitTests_Control/ControlCoreTests.cpp (+5 -2)
📝 src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp (+4 -2)

📄 Description

In #11180 we made opacity independent from useAcrylic. We also changed the mouse wheel behavior to only change opacity, and not mess with acrylic.

However, on Windows 10, vintage opacity doesn't work at all. So there, we still need to manually enable acrylic when the user requests opacity.

SUI changes in action:

auto-acrylic-win10


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11372 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 9/29/2021 **Status:** ✅ Merged **Merged:** 10/7/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11285-opacity-on-win10` --- ### 📝 Commits (10+) - [`93831f1`](https://github.com/microsoft/terminal/commit/93831f1bbc98b30192ef8782636038b7f0c062e7) When enabling opacity on win10, automatically enable acrylic - [`0ee8817`](https://github.com/microsoft/terminal/commit/0ee8817e8202eb8b61b622c72ddf3062407e3483) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11285-opacity-on-win10 - [`0af9c4d`](https://github.com/microsoft/terminal/commit/0af9c4d2a148a580299d0a791eb3da6cdea7a407) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11285-opacity-on-win10 - [`7fd3fb7`](https://github.com/microsoft/terminal/commit/7fd3fb78b9012497378d6c4f0a4a1045ad595787) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11285-opacity-on-win10 - [`2805557`](https://github.com/microsoft/terminal/commit/28055574310442568effcfebf43482297fd5d51d) these were pr nits - [`2e509d3`](https://github.com/microsoft/terminal/commit/2e509d3aeee3f5f0e0e287136364727a05c70af1) this does the auto-opacity thing, but does it on all versions - [`3347d9c`](https://github.com/microsoft/terminal/commit/3347d9c0b9b55e856249a1371da5408dbf22c0a2) fix the sui for @carlos-zamora - [`2ea7f4b`](https://github.com/microsoft/terminal/commit/2ea7f4b4a2f89a35953f168b39717608b94b880b) sometimes I don't always buid the code - [`a3cbc30`](https://github.com/microsoft/terminal/commit/a3cbc30ec18ebacd48057ffc35f4c7333df36d10) yea of course this is it' - [`0b6d428`](https://github.com/microsoft/terminal/commit/0b6d428ecad44e2866b0c5e6cfb5adf2b18cd43e) this should fix the tests ### 📊 Changes **6 files changed** (+76 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+35 -0) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+16 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.h` (+14 -0) 📝 `src/cascadia/UnitTests_Control/ControlCoreTests.cpp` (+5 -2) 📝 `src/cascadia/UnitTests_Control/ControlInteractivityTests.cpp` (+4 -2) </details> ### 📄 Description In #11180 we made `opacity` independent from `useAcrylic`. We also changed the mouse wheel behavior to only change opacity, and not mess with acrylic. However, on Windows 10, vintage opacity doesn't work at all. So there, we still need to manually enable acrylic when the user requests opacity. * [x] Closes #11285 SUI changes in action: ![auto-acrylic-win10](https://user-images.githubusercontent.com/18356694/136281935-db9a10f4-e0ad-4422-950b-0a01dc3e12c0.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:05 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28525