[PR #11397] [MERGED] Add a information popup about default terminals #28557

Open
opened 2026-01-31 09:29:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11397
Author: @lhecker
Created: 10/2/2021
Status: ✅ Merged
Merged: 10/7/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/default-terminal-popup


📝 Commits (5)

  • 752ab6c Add a information popup about default terminals
  • b8a324f Fix serialization
  • 3b67f34 Address Carlos' comments
  • ffae725 Merge remote-tracking branch 'origin/main' into dev/lhecker/default-terminal-popup
  • 7c2fb63 Address Dustin's comments

📊 Changes

11 files changed (+99 additions, -7 deletions)

View changed files

📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+53 -5)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+13 -0)
📝 src/cascadia/TerminalSettingsModel/ApplicationState.idl (+2 -1)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+11 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.idl (+1 -0)
📝 src/cascadia/TerminalSettingsModel/DefaultTerminal.cpp (+10 -0)
📝 src/cascadia/TerminalSettingsModel/DefaultTerminal.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h (+2 -1)

📄 Description

This commit adds a simple information popup about default terminals,
guiding first-time Windows 11 users into changing the default terminal.

Validation Steps Performed

  • Info bar pops up on Windows 11 ✔️
  • Info bar can be dismissed persistently ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11397 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 10/2/2021 **Status:** ✅ Merged **Merged:** 10/7/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/default-terminal-popup` --- ### 📝 Commits (5) - [`752ab6c`](https://github.com/microsoft/terminal/commit/752ab6ce713a7c0caf9beddc6447d538bd1f917f) Add a information popup about default terminals - [`b8a324f`](https://github.com/microsoft/terminal/commit/b8a324fd2b162e83b7fd7cf33324797848468fa1) Fix serialization - [`3b67f34`](https://github.com/microsoft/terminal/commit/3b67f34e6b168dd659f29566e4c9cb022f326485) Address Carlos' comments - [`ffae725`](https://github.com/microsoft/terminal/commit/ffae72553d738b2a69ced9d2e5c2d49c7da2515c) Merge remote-tracking branch 'origin/main' into dev/lhecker/default-terminal-popup - [`7c2fb63`](https://github.com/microsoft/terminal/commit/7c2fb63dac25cfcee2a4e22a1cb99c44c219eccf) Address Dustin's comments ### 📊 Changes **11 files changed** (+99 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+53 -5) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+13 -0) 📝 `src/cascadia/TerminalSettingsModel/ApplicationState.idl` (+2 -1) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+11 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.idl` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/DefaultTerminal.cpp` (+10 -0) 📝 `src/cascadia/TerminalSettingsModel/DefaultTerminal.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettingsSerializationHelpers.h` (+2 -1) </details> ### 📄 Description This commit adds a simple information popup about default terminals, guiding first-time Windows 11 users into changing the default terminal. ## Validation Steps Performed * Info bar pops up on Windows 11 ✔️ * Info bar can be dismissed persistently ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28557