[PR #11416] [MERGED] Use X-macros to simplify new setting creation in SettingsModel #28564

Open
opened 2026-01-31 09:29:19 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11416
Author: @PankajBhojwani
Created: 10/4/2021
Status: Merged
Merged: 11/3/2021
Merged by: @undefined

Base: mainHead: dev/pabhoj/simplify_add_setting


📝 Commits (10+)

📊 Changes

11 files changed (+190 additions, -378 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp (+17 -44)
📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.h (+5 -14)
📝 src/cascadia/TerminalSettingsModel/FontConfig.cpp (+14 -20)
📝 src/cascadia/TerminalSettingsModel/FontConfig.h (+5 -5)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp (+15 -162)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.h (+6 -39)
src/cascadia/TerminalSettingsModel/MTSMSettings.h (+96 -0)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Profile.cpp (+15 -67)
📝 src/cascadia/TerminalSettingsModel/Profile.h (+15 -27)

📄 Description

Introduces X-macros to reduce the number of places we need to write essentially the same line of code but for a different setting (declaring it in the header file, in Copy, LayerJson, ToJson, etc).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11416 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 10/4/2021 **Status:** ✅ Merged **Merged:** 11/3/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/simplify_add_setting` --- ### 📝 Commits (10+) - [`3236268`](https://github.com/microsoft/terminal/commit/3236268fd30117e8f84e07fe1037dfa564edd63d) first pass - [`f8f16f6`](https://github.com/microsoft/terminal/commit/f8f16f64551d4712e390d672d2cefbcfcc7dd57f) format - [`83e206c`](https://github.com/microsoft/terminal/commit/83e206ceae2030ff55e400da334f2b171caa3392) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/simplify_add_setting - [`b1d474c`](https://github.com/microsoft/terminal/commit/b1d474c33d19d09b7f7b26c7e2e89d764ceac8ac) app settings - [`85f4873`](https://github.com/microsoft/terminal/commit/85f487389d27df763cb71e10a631869e8d1045fa) format - [`6941bba`](https://github.com/microsoft/terminal/commit/6941bbabfcc3113725da22b1e737a0060847d2e9) macrofy font config - [`24b8719`](https://github.com/microsoft/terminal/commit/24b87191b7d4cb768dd54f63e23f6efd0fba8cb7) formatt - [`f41426b`](https://github.com/microsoft/terminal/commit/f41426bc33dbe6518095fb1dee8da3e93bd40582) placeholder macros - [`1b4a5fa`](https://github.com/microsoft/terminal/commit/1b4a5fad8e92f075d1b43f1ab289f52240124ceb) scale it back - [`294c980`](https://github.com/microsoft/terminal/commit/294c980b977c3f5bc1210c0cb774549391c3ef60) reduce diff ### 📊 Changes **11 files changed** (+190 additions, -378 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp` (+17 -44) 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.h` (+5 -14) 📝 `src/cascadia/TerminalSettingsModel/FontConfig.cpp` (+14 -20) 📝 `src/cascadia/TerminalSettingsModel/FontConfig.h` (+5 -5) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp` (+15 -162) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.h` (+6 -39) ➕ `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+96 -0) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Profile.cpp` (+15 -67) 📝 `src/cascadia/TerminalSettingsModel/Profile.h` (+15 -27) </details> ### 📄 Description Introduces X-macros to reduce the number of places we need to write essentially the same line of code but for a different setting (declaring it in the header file, in `Copy`, `LayerJson`, `ToJson`, etc). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:19 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28564