[PR #11442] [MERGED] Wire up RadioButtons as groups in UIA #28575

Open
opened 2026-01-31 09:29:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11442
Author: @zadjii-msft
Created: 10/6/2021
Status: Merged
Merged: 10/7/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/11248-radio-btn-groups


📝 Commits (1)

  • ef52195 Wire up RadioButtons as groups in UIA

📊 Changes

6 files changed (+29 additions, -14 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/AddProfile.xaml (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+6 -3)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml (+4 -2)
📝 src/cascadia/TerminalSettingsEditor/Interaction.xaml (+4 -2)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+8 -4)
📝 src/cascadia/TerminalSettingsEditor/Profiles.xaml (+6 -3)

📄 Description

I thought that microsoft/microsoft-ui-xaml#3183 might just fix this for us, but it didn't. We've got our RadioButton's all up in SettingsContainers, so they all think they're AutomationProperties.AccessibilityView="Raw" for some reason. If you simply add the Content to these, then they all end up correct in Accessibility Insights

PR Checklist

  • Will take care of #11248 but I can't be the one to close it.
  • I work here
  • Tests added/passed
  • [n/a] Requires documentation to be updated

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11442 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 10/6/2021 **Status:** ✅ Merged **Merged:** 10/7/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11248-radio-btn-groups` --- ### 📝 Commits (1) - [`ef52195`](https://github.com/microsoft/terminal/commit/ef52195e07513311bd7bf1930591dd245ffa7085) Wire up RadioButtons as groups in UIA ### 📊 Changes **6 files changed** (+29 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/AddProfile.xaml` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+6 -3) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml` (+4 -2) 📝 `src/cascadia/TerminalSettingsEditor/Interaction.xaml` (+4 -2) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+8 -4) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.xaml` (+6 -3) </details> ### 📄 Description I thought that microsoft/microsoft-ui-xaml#3183 might just fix this for us, but it didn't. We've got our RadioButton's all up in SettingsContainers, so they all think they're `AutomationProperties.AccessibilityView="Raw"` for some reason. If you simply add the `Content` to these, then they all end up correct in Accessibility Insights ## PR Checklist * [x] Will take care of #11248 but I can't be the one to close it. * [x] I work here * [x] Tests added/passed * [n/a] Requires documentation to be updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:22 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28575