starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11440] [MERGED] Try to fix crash on close with saving enabled #28576

New Issue
Open
opened 2026-01-31 09:29:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:29:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11440
Author: @Rosefield
Created: 10/6/2021
Status: ✅ Merged
Merged: 10/20/2021
Merged by: @PankajBhojwani

Base: main ← Head: bug/dont-crash-on-close

📝 Commits (2)

  • 2233047 dont crash if we try to save the window layout while we are closing, and try to avoid saving at all
  • add7d0a Remove ourself from the list of peasants before we start destructing this way any concurrent event handlers will finish, and future ones will not include us.

📊 Changes

2 files changed (+38 additions, -13 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/AppHost.cpp (+37 -13)
📝 src/cascadia/WindowsTerminal/AppHost.h (+1 -0)

📄 Description

Don't crash if we try to save the window layout while we are closing, and try to avoid saving at all.

Might impact #11354

Detailed Description of the Pull Request / Additional comments

  • Revoke the event handler/save throttler so we don't even try to get the window layout when we are closing
  • Try to check for nullptrs, but then apply try {} CATCH_LOG() liberally

Validation Steps Performed

The happy path of saving normally is still fine, but I haven't been unlucky enough to trigger the crash myself.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11440 **Author:** [@Rosefield](https://github.com/Rosefield) **Created:** 10/6/2021 **Status:** ✅ Merged **Merged:** 10/20/2021 **Merged by:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Base:** `main` ← **Head:** `bug/dont-crash-on-close` --- ### 📝 Commits (2) - [`2233047`](https://github.com/microsoft/terminal/commit/22330477c532bbf846cb7ebcaec86fc86cf07734) dont crash if we try to save the window layout while we are closing, and try to avoid saving at all - [`add7d0a`](https://github.com/microsoft/terminal/commit/add7d0ad737a1acf66d65b855ff821ad84f7d650) Remove ourself from the list of peasants before we start destructing this way any concurrent event handlers will finish, and future ones will not include us. ### 📊 Changes **2 files changed** (+38 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+37 -13) 📝 `src/cascadia/WindowsTerminal/AppHost.h` (+1 -0) </details> ### 📄 Description Don't crash if we try to save the window layout while we are closing, and try to avoid saving at all. Might impact #11354 ## Detailed Description of the Pull Request / Additional comments - Revoke the event handler/save throttler so we don't even try to get the window layout when we are closing - Try to check for nullptrs, but then apply `try {} CATCH_LOG()` liberally ## Validation Steps Performed The happy path of saving normally is still fine, but I haven't been unlucky enough to trigger the crash myself. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?