starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11466] [MERGED] Enable fast floating point model and fast debug linking #28594

New Issue
Open
opened 2026-01-31 09:29:31 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:29:31 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11466
Author: @lhecker
Created: 10/8/2021
Status: ✅ Merged
Merged: 10/11/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/compiler-options

📝 Commits (8)

  • 7c07c3c Enable fast floating point model and fast debug linking
  • ccff6f6 Introduce ULP based float comparisons
  • ac7c7c2 Fix formatting
  • f92ccba Fix spellcheck
  • 30eede7 Fix build error
  • 4948902 Remove accidential comment
  • 75441d6 Replaced reinterpret_cast hack with til::bit_cast
  • 3971782 Fix build error again

📊 Changes

7 files changed (+71 additions, -3 deletions)

View changed files

📝 .github/actions/spelling/allow/math.txt (+1 -0)
📝 src/buffer/out/TextColor.cpp (+4 -2)
📝 src/cascadia/ut_app/ColorHelperTests.cpp (+3 -0)
📝 src/common.build.pre.props (+5 -0)
📝 src/inc/consoletaeftemplates.hpp (+41 -0)
➕ src/inc/til/bit.h (+16 -0)
📝 src/project.inc (+1 -1)

📄 Description

This commit enables /fp:fast. This doubles the performance of the Delta E
computation in #11095 for instance. Additionally it re-enables two options for
debug builds which are normally enabled by default by Visual Studio.

PR Checklist

  • I work here
  • Tests added/passed

Validation Steps Performed

  • No change in binary size
  • No obvious change in behavior

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11466 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 10/8/2021 **Status:** ✅ Merged **Merged:** 10/11/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/compiler-options` --- ### 📝 Commits (8) - [`7c07c3c`](https://github.com/microsoft/terminal/commit/7c07c3c7a6fbc54cf589623fa33c5746224d758b) Enable fast floating point model and fast debug linking - [`ccff6f6`](https://github.com/microsoft/terminal/commit/ccff6f68beb041189c2b8bd5c04d6ac3674eb79e) Introduce ULP based float comparisons - [`ac7c7c2`](https://github.com/microsoft/terminal/commit/ac7c7c2b23744b66d7c0f2913a94375e2634965d) Fix formatting - [`f92ccba`](https://github.com/microsoft/terminal/commit/f92ccba9c010d5e6d1e320230a6f5cd492e392eb) Fix spellcheck - [`30eede7`](https://github.com/microsoft/terminal/commit/30eede7f5341c70c52fb68f2cc233a7038a14c80) Fix build error - [`4948902`](https://github.com/microsoft/terminal/commit/4948902d791b9e3add6b95a2f42143eb693b6d88) Remove accidential comment - [`75441d6`](https://github.com/microsoft/terminal/commit/75441d6889dddbe3fcd69e5480b6e01880759d8c) Replaced reinterpret_cast hack with til::bit_cast - [`3971782`](https://github.com/microsoft/terminal/commit/397178257c1dcb8564bb5b40c7b01102514b03e9) Fix build error again ### 📊 Changes **7 files changed** (+71 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/math.txt` (+1 -0) 📝 `src/buffer/out/TextColor.cpp` (+4 -2) 📝 `src/cascadia/ut_app/ColorHelperTests.cpp` (+3 -0) 📝 `src/common.build.pre.props` (+5 -0) 📝 `src/inc/consoletaeftemplates.hpp` (+41 -0) ➕ `src/inc/til/bit.h` (+16 -0) 📝 `src/project.inc` (+1 -1) </details> ### 📄 Description This commit enables /fp:fast. This doubles the performance of the Delta E computation in #11095 for instance. Additionally it re-enables two options for debug builds which are normally enabled by default by Visual Studio. ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * No change in binary size * No obvious change in behavior --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28594
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?