[PR #11489] [MERGED] Further reduce number of generated VS profiles #28607

Open
opened 2026-01-31 09:29:37 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11489
Author: @lhecker
Created: 10/12/2021
Status: ✅ Merged
Merged: 10/20/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/visual-studio-generator-verbosity


📝 Commits (3)

  • 0162aae Further reduce number of generated VS profiles
  • fd8790b Revert most, keep -arch
  • 4aaaf03 Fix build

📊 Changes

9 files changed (+30 additions, -168 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj (+1 -3)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters (+1 -7)
➖ src/cascadia/TerminalSettingsModel/VcDevCmdGenerator.cpp (+0 -94)
➖ src/cascadia/TerminalSettingsModel/VcDevCmdGenerator.h (+0 -40)
📝 src/cascadia/TerminalSettingsModel/VisualStudioGenerator.cpp (+0 -4)
📝 src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp (+9 -2)
📝 src/cascadia/TerminalSettingsModel/VsDevShellGenerator.cpp (+13 -4)
📝 src/cascadia/TerminalSettingsModel/VsSetupConfiguration.cpp (+3 -9)
📝 src/cascadia/TerminalSettingsModel/VsSetupConfiguration.h (+3 -5)

📄 Description

This commit reduces the number of generated VS profiles from 6 down to just 2
per VS instance. The reason we did this is out of concern of overwhelming or
annoying new users with too many profiles. Especially since it's far easier
at the moment to add new generators compared to removing them.

As before only the latest instance is not hidden by default.

PR Checklist

  • I work here
  • Tests added/passed
  • As discussed in a Team Sync meeting

Validation Steps Performed

  • Installed Visual Studio 2019 and 2022 Preview
  • A profile for both is generated, while the 2019 one is hidden by default ✔️
  • $env:VSCMD_ARG_TGT_ARCH is x64 on my AMD64 machine ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11489 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 10/12/2021 **Status:** ✅ Merged **Merged:** 10/20/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/visual-studio-generator-verbosity` --- ### 📝 Commits (3) - [`0162aae`](https://github.com/microsoft/terminal/commit/0162aae3e69a4969287936f04e6b8e0d1ce53497) Further reduce number of generated VS profiles - [`fd8790b`](https://github.com/microsoft/terminal/commit/fd8790bed643451fe8360f2ecee6d5eb90d7668c) Revert most, keep -arch - [`4aaaf03`](https://github.com/microsoft/terminal/commit/4aaaf03b00365eb953be1733339825bc54805398) Fix build ### 📊 Changes **9 files changed** (+30 additions, -168 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj` (+1 -3) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj.filters` (+1 -7) ➖ `src/cascadia/TerminalSettingsModel/VcDevCmdGenerator.cpp` (+0 -94) ➖ `src/cascadia/TerminalSettingsModel/VcDevCmdGenerator.h` (+0 -40) 📝 `src/cascadia/TerminalSettingsModel/VisualStudioGenerator.cpp` (+0 -4) 📝 `src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp` (+9 -2) 📝 `src/cascadia/TerminalSettingsModel/VsDevShellGenerator.cpp` (+13 -4) 📝 `src/cascadia/TerminalSettingsModel/VsSetupConfiguration.cpp` (+3 -9) 📝 `src/cascadia/TerminalSettingsModel/VsSetupConfiguration.h` (+3 -5) </details> ### 📄 Description This commit reduces the number of generated VS profiles from 6 down to just 2 per VS instance. The reason we did this is out of concern of overwhelming or annoying new users with too many profiles. Especially since it's far easier at the moment to add new generators compared to removing them. As before only the latest instance is not hidden by default. ## PR Checklist * [x] I work here * [x] Tests added/passed * [x] As discussed in a Team Sync meeting ## Validation Steps Performed * Installed Visual Studio 2019 and 2022 Preview * A profile for both is generated, while the 2019 one is hidden by default ✔️ * $env:VSCMD_ARG_TGT_ARCH is x64 on my AMD64 machine ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:37 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28607