starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11537] [MERGED] Add even MORE logging for defterm #28637

New Issue
Open
opened 2026-01-31 09:29:47 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:29:47 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11537
Author: @zadjii-msft
Created: 10/19/2021
Status: ✅ Merged
Merged: 10/19/2021
Merged by: @PankajBhojwani

Base: main ← Head: dev/migrie/more-defterm-logging

📝 Commits (4)

  • c8e0336 Add even MORE logging for defterm
  • 58fcf99 I literally cannot spell that word right
  • 3e806dc formatting
  • 19c1b00 somehow I knew this would bite me

📊 Changes

4 files changed (+115 additions, -8 deletions)

View changed files

📝 src/Terminal.wprp (+32 -1)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+10 -0)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+16 -7)
📝 src/host/srvinit.cpp (+57 -0)

📄 Description

Considering the number of reports of "defterm isn't working (mysteriously)", I figured more logging current hurt. I also added a wprp profile for the defterm logging as well, which should capture conhost side things as well.

From an elevated conhost:

wpr -start path\to\Terminal.wprp!Defterm.Verbose
wpr -stop %USERPROFILE%\defterm-trace.etl

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11537 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 10/19/2021 **Status:** ✅ Merged **Merged:** 10/19/2021 **Merged by:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Base:** `main` ← **Head:** `dev/migrie/more-defterm-logging` --- ### 📝 Commits (4) - [`c8e0336`](https://github.com/microsoft/terminal/commit/c8e0336813ab7db344488219937783f685a7d009) Add even MORE logging for defterm - [`58fcf99`](https://github.com/microsoft/terminal/commit/58fcf99a6381b8d7e88c24da4e06a94783be3024) I literally cannot spell that word right - [`3e806dc`](https://github.com/microsoft/terminal/commit/3e806dcb77d6935e1591536b4f875c50afe30d9f) formatting - [`19c1b00`](https://github.com/microsoft/terminal/commit/19c1b0091fb461c50ae0053128bae843f715e056) somehow I knew this would bite me ### 📊 Changes **4 files changed** (+115 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/Terminal.wprp` (+32 -1) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+10 -0) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+16 -7) 📝 `src/host/srvinit.cpp` (+57 -0) </details> ### 📄 Description Considering the number of reports of "defterm isn't working (mysteriously)", I figured more logging current hurt. I also added a wprp profile for the defterm logging as well, which should capture conhost side things as well. From an elevated conhost: ``` wpr -start path\to\Terminal.wprp!Defterm.Verbose wpr -stop %USERPROFILE%\defterm-trace.etl ``` * [x] I work here * [x] relevant to: #10594, #11529, #11524. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:47 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28637
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?