[PR #11554] [MERGED] Fixed VsDevCmd command line quoting #28647

Open
opened 2026-01-31 09:29:51 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11554
Author: @lhecker
Created: 10/20/2021
Status: ✅ Merged
Merged: 10/20/2021
Merged by: @lhecker

Base: main ← Head: dev/lhecker/11552-fix-vs-generator


📝 Commits (1)

  • 1992fab Fixed VsDevCmd command line quoting

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp (+1 -1)

📄 Description

An extra " sneaked in when I changed the code
from string literals to raw string literals.

PR Checklist

Validation Steps Performed

  • Developer PowerShell for VS 2022 [Preview] profile exists ✔️
    • Launches developer PowerShell ✔️
    • $env:VSCMD_ARG_TGT_ARCH is x64 ✔️
  • Developer Command Prompt for VS 2022 [Preview] profile exists ✔️
    • Launches regular developer shell ✔️
    • %VSCMD_ARG_TGT_ARCH% is x64 ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11554 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 10/20/2021 **Status:** ✅ Merged **Merged:** 10/20/2021 **Merged by:** [@lhecker](https://github.com/lhecker) **Base:** `main` ← **Head:** `dev/lhecker/11552-fix-vs-generator` --- ### 📝 Commits (1) - [`1992fab`](https://github.com/microsoft/terminal/commit/1992fab6f0dc06cc97cdd5e5914817d5dcfa4ec0) Fixed VsDevCmd command line quoting ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/VsDevCmdGenerator.cpp` (+1 -1) </details> ### 📄 Description An extra `"` sneaked in when I changed the code from string literals to raw string literals. ## PR Checklist * [x] Closes #11552 * [x] I work here ## Validation Steps Performed * `Developer PowerShell for VS 2022 [Preview]` profile exists ✔️ * Launches developer PowerShell ✔️ * `$env:VSCMD_ARG_TGT_ARCH` is `x64` ✔️ * `Developer Command Prompt for VS 2022 [Preview]` profile exists ✔️ * Launches regular developer shell ✔️ * `%VSCMD_ARG_TGT_ARCH%` is `x64` ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:29:51 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28647