starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Solarized Light's brightWhite and background are set to the same color #2868

New Issue
Closed
opened 2026-01-30 23:07:32 +00:00 by claunia · 11 comments
claunia commented 2026-01-30 23:07:32 +00:00
Owner
Copy Link

Originally created by @llinfeng on GitHub (Jul 21, 2019).

Bug report: Simple man cp does not reveal readable documentation when issued in Windows Terminal. ConEmu does the job properly. Note, I got the same "display problem" across the local machine (Windows 10 + WSL) and a two remote Linux boxes using SSH connection.

For the following screenshot, I used ConEmu on the left and Windows Terminal on the right. Same issue with man ls as shown in the screenshot.

image

Originally created by @llinfeng on GitHub (Jul 21, 2019). **Bug report**: Simple `man cp` does not reveal readable documentation when issued in Windows Terminal. ConEmu does the job properly. Note, I got the same "display problem" across the local machine (Windows 10 + WSL) and a two remote Linux boxes using SSH connection. For the following screenshot, I used ConEmu on the left and Windows Terminal on the right. Same issue with `man ls` as shown in the screenshot. ![image](https://user-images.githubusercontent.com/5890407/61598207-f2c06180-abe7-11e9-861f-22adc2578be4.png)
claunia added the Help WantedArea-SettingsIssue-BugNeeds-Tag-FixProduct-Terminal labels 2026-01-30 23:07:32 +00:00
claunia commented 2026-01-30 23:07:33 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 22, 2019):

Hey, it looks like this is just because Solarized Light's brightWhite and background are set to the same color. That's not right.

@DHowett-MSFT commented on GitHub (Jul 22, 2019): Hey, it looks like this is just because Solarized Light's `brightWhite` and `background` are set to the same color. That's not right.
claunia commented 2026-01-30 23:07:33 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 22, 2019):

            "background": "#FDF6E3",
            "brightWhite": "#FDF6E3",
            "name": "Solarized Light",
@DHowett-MSFT commented on GitHub (Jul 22, 2019): ``` "background": "#FDF6E3", "brightWhite": "#FDF6E3", "name": "Solarized Light", ```
claunia commented 2026-01-30 23:07:33 +00:00
Author
Owner
Copy Link

@llinfeng commented on GitHub (Jul 23, 2019):

Aha, great catch! I changed the color for "brightWhite" to be the following. Manuals are readable now.

            "brightWhite" : "#1ea2ca",
@llinfeng commented on GitHub (Jul 23, 2019): Aha, great catch! I changed the color for `"brightWhite"` to be the following. Manuals are readable now. ``` "brightWhite" : "#1ea2ca", ```
claunia commented 2026-01-30 23:07:33 +00:00
Author
Owner
Copy Link

@dander commented on GitHub (Jul 24, 2019):

I assume this would apply to these as well?

            "background" : "#002B36",
            "brightBlack" : "#002B36",
            "name" : "Solarized Dark",
@dander commented on GitHub (Jul 24, 2019): I assume this would apply to these as well? ``` "background" : "#002B36", "brightBlack" : "#002B36", "name" : "Solarized Dark", ```
claunia commented 2026-01-30 23:07:33 +00:00
Author
Owner
Copy Link

@llinfeng commented on GitHub (Jul 30, 2019):

I am happy with the following color-settings for Solarized Light. It is hand-crafted only to make the terminal more readable. In addition to the brightWhite entry, I also updated the green and blue keys.

        {
            "background" : "#FDF6E3",
            "black" : "#073642",
            "blue" : "#004f87",
            "brightBlack" : "#002B36",
            "brightBlue" : "#839496",
            "brightCyan" : "#93A1A1",
            "brightGreen" : "#586E75",
            "brightPurple" : "#6C71C4",
            "brightRed" : "#CB4B16",
            "brightWhite" : "#1EA2CA",
            "brightYellow" : "#657B83",
            "cyan" : "#2AA198",
            "foreground" : "#073642",
            "green" : "#bac474",
            "name" : "Solarized Light",
            "purple" : "#D33682",
            "red" : "#D30102",
            "white" : "#EEE8D5",
            "yellow" : "#B58900"
        }

I use zsh as my shell, with theme: ZSH_THEME="robbyrussell". With the green entry at its default value, I see something hard to read when listing files in a directory.
image

@llinfeng commented on GitHub (Jul 30, 2019): I am happy with the following color-settings for `Solarized Light`. It is hand-crafted only to make the terminal more readable. In addition to the `brightWhite` entry, I also updated the `green` and `blue` keys. ``` { "background" : "#FDF6E3", "black" : "#073642", "blue" : "#004f87", "brightBlack" : "#002B36", "brightBlue" : "#839496", "brightCyan" : "#93A1A1", "brightGreen" : "#586E75", "brightPurple" : "#6C71C4", "brightRed" : "#CB4B16", "brightWhite" : "#1EA2CA", "brightYellow" : "#657B83", "cyan" : "#2AA198", "foreground" : "#073642", "green" : "#bac474", "name" : "Solarized Light", "purple" : "#D33682", "red" : "#D30102", "white" : "#EEE8D5", "yellow" : "#B58900" } ``` I use `zsh` as my shell, with theme: `ZSH_THEME="robbyrussell"`. With the `green` entry at its default value, I see something hard to read when listing files in a directory. ![image](https://user-images.githubusercontent.com/5890407/62151929-6db40700-b2cf-11e9-8c5d-2bb9ca5d7ed4.png)
claunia commented 2026-01-30 23:07:34 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jul 30, 2019):

But now you just don't have green. It seems like a global fix ("delete green") for a local problem ("ls uses blue on green for srwx folders"). That latter bit is configurable with dircolors/LS_COLORS.

@DHowett-MSFT commented on GitHub (Jul 30, 2019): But now you just don't have green. It seems like a global fix ("delete green") for a local problem ("ls uses blue on green for `srwx` folders"). That latter bit is configurable with dircolors/`LS_COLORS`.
claunia commented 2026-01-30 23:07:34 +00:00
Author
Owner
Copy Link

@antoineco commented on GitHub (Aug 22, 2019):

Possibly related to / caused by #293

@antoineco commented on GitHub (Aug 22, 2019): Possibly related to / caused by #293
claunia commented 2026-01-30 23:07:34 +00:00
Author
Owner
Copy Link

@kojoru commented on GitHub (Aug 30, 2019):

@DHowett-MSFT

Can we reopen this? Right now the experience is like that:

  1. Install git, powershell core and terminal
  2. Set powershell colors to solarized dark
  3. Type "git add --all" in terminal

Expected result: the whole command is visible
Actual result: "--all" is the same colour as the background.

That's definitely caused by having "brightBlack" to be the same as "background", but I'm not sure which colour it should be instead, or whether changing it in the terminal is the right approach.

The problem is definitely there though.

@kojoru commented on GitHub (Aug 30, 2019): @DHowett-MSFT Can we reopen this? Right now the experience is like that: 1) Install git, powershell core and terminal 2) Set powershell colors to solarized dark 3) Type "git add --all" in terminal Expected result: the whole command is visible Actual result: "--all" is the same colour as the background. That's definitely caused by having "brightBlack" to be the same as "background", but I'm not sure which colour it should be instead, or whether changing it in the terminal is the right approach. The problem is definitely there though.
claunia commented 2026-01-30 23:07:35 +00:00
Author
Owner
Copy Link

@antoineco commented on GitHub (Aug 31, 2019):

@kojoru background is supposed to be set to the same color as "bright black" in the Solarized palette (base03). The problem here is the Powershell highlighting, not the Solarized colors.

Please also note that Terminal currently displays a few colors incorrectly due to a bug. See https://github.com/microsoft/terminal/issues/293#issuecomment-506065103

I temporarily changed my background color to an almost identical color to get around the issue.

@antoineco commented on GitHub (Aug 31, 2019): @kojoru background _is_ supposed to be set to the same color as "bright black" in the [Solarized palette](https://github.com/altercation/solarized#the-values) (base03). The problem here is the Powershell highlighting, not the Solarized colors. Please also note that Terminal currently displays a few colors incorrectly due to a bug. See https://github.com/microsoft/terminal/issues/293#issuecomment-506065103 I temporarily changed my background color to an almost identical color to get around the issue.
claunia commented 2026-01-30 23:07:35 +00:00
Author
Owner
Copy Link

@kojoru commented on GitHub (Sep 2, 2019):

@antoineco this is surely a least usability issue though, given both terminal and powershell are microsoft products that are set up using pretty much stock defaults?

As an aside, I'm not actually sure where the color highlighting comes from in powershell. Is that part of https://github.com/PowerShell/PowerShell/? Can I customize that myselft?

@kojoru commented on GitHub (Sep 2, 2019): @antoineco this is surely a least usability issue though, given both terminal and powershell are microsoft products that are set up using pretty much stock defaults? As an aside, I'm not actually sure where the color highlighting comes from in powershell. Is that part of https://github.com/PowerShell/PowerShell/? Can I customize that myselft?
claunia commented 2026-01-30 23:07:35 +00:00
Author
Owner
Copy Link

@antoineco commented on GitHub (Sep 2, 2019):

@kojoru I agree that Solarized is always a tricky color scheme to use. Whether in Bash/Zsh or PowerShell, you often have to configure terminal applications to output non-default colors due to Solarized using 16 colors instead of 8 (the standard).

You can change the highlighting of PowerShell commands using Set-PSReadlineOption.

If you also need git colors that work well with Solarized (to add to your .gitconfig file), for example for a prettier git log output, I recommend using these settings.

@antoineco commented on GitHub (Sep 2, 2019): @kojoru I agree that Solarized is always a tricky color scheme to use. Whether in Bash/Zsh or PowerShell, you often have to configure terminal applications to output non-default colors due to Solarized using 16 colors instead of 8 (the standard). You can change the highlighting of PowerShell commands using [` Set-PSReadlineOption`](https://4sysops.com/wiki/change-powershell-console-syntax-highlighting-colors-of-psreadline/#token-colors). If you also need git colors that work well with Solarized (to add to your .gitconfig file), for example for a prettier `git log` output, I recommend using [these settings](https://github.com/antoineco/dotfiles/blob/master/gitconfig#L15-L24).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?