[PR #11674] [MERGED] Don't crash if we fail to BeginBufferedPaint #28707

Open
opened 2026-01-31 09:30:16 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11674
Author: @zadjii-msft
Created: 11/2/2021
Status: Merged
Merged: 11/5/2021
Merged by: @undefined

Base: mainHead: dev/migrie/b/msft-34673647


📝 Commits (1)

  • aef285a Don't crash if we fail to BeginBufferedPaint

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+5 -1)

📄 Description

Fixes MSFT:34673647, at least I'm pretty sure. That's only ever hit a few
times externally, and internally it's hitting a lot on 1.9.1942 builds, which
doesn't really make any sense.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11674 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 11/2/2021 **Status:** ✅ Merged **Merged:** 11/5/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/msft-34673647` --- ### 📝 Commits (1) - [`aef285a`](https://github.com/microsoft/terminal/commit/aef285aa83e0a5a46c44ef541108d81ded534986) Don't crash if we fail to BeginBufferedPaint ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+5 -1) </details> ### 📄 Description Fixes MSFT:34673647, at least I'm pretty sure. That's only ever hit a few times externally, and internally it's hitting a lot on 1.9.1942 builds, which doesn't really make any sense. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:16 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28707