[PR #11720] [MERGED] Update our SUI to follow win 11 guidelines #28718

Open
opened 2026-01-31 09:30:21 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11720
Author: @PankajBhojwani
Created: 11/9/2021
Status: Merged
Merged: 1/28/2022
Merged by: @PankajBhojwani

Base: mainHead: dev/pabhoj/SUI_11


📝 Commits (10+)

📊 Changes

14 files changed (+933 additions, -127 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Actions.xaml (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+13 -9)
📝 src/cascadia/TerminalSettingsEditor/CommonResources.xaml (+647 -24)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml (+20 -11)
📝 src/cascadia/TerminalSettingsEditor/Interaction.xaml (+20 -11)
📝 src/cascadia/TerminalSettingsEditor/Launch.xaml (+43 -24)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+2 -3)
📝 src/cascadia/TerminalSettingsEditor/Profiles.xaml (+21 -13)
📝 src/cascadia/TerminalSettingsEditor/Rendering.xaml (+4 -2)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+7 -11)
📝 src/cascadia/TerminalSettingsEditor/SettingContainer.cpp (+21 -0)
📝 src/cascadia/TerminalSettingsEditor/SettingContainer.h (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/SettingContainer.idl (+3 -0)
📝 src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml (+130 -19)

📄 Description

Summary of the Pull Request

Updates our SUI to follow the windows 11 style guidelines. Includes updating our setting containers to follow the 'expander' style.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11720 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 11/9/2021 **Status:** ✅ Merged **Merged:** 1/28/2022 **Merged by:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Base:** `main` ← **Head:** `dev/pabhoj/SUI_11` --- ### 📝 Commits (10+) - [`0b58355`](https://github.com/microsoft/terminal/commit/0b58355ef4b7b81b7b9d1a3ca99810dbcf9eaa6c) testing - [`ba4faec`](https://github.com/microsoft/terminal/commit/ba4faec04fa7761742c155bbd1345de0341e3d0f) got 2 styles that kinda work I guess - [`f3fd857`](https://github.com/microsoft/terminal/commit/f3fd85731dbdcc65f15c8bb254e0dbaaae4e643a) apparently this is the old expander - [`13bbcbf`](https://github.com/microsoft/terminal/commit/13bbcbf50f9476f22fd78a4e7f803e4de9d30f13) just use muxc:expander - [`81d0c5c`](https://github.com/microsoft/terminal/commit/81d0c5c2d7a28ecbaee9b2ce9f1337d64ce79305) remove remnants of previous implementation, format - [`61ae0a1`](https://github.com/microsoft/terminal/commit/61ae0a1a774feea8e116614e7c146aec794fcdf5) carlos comments - [`e6dffda`](https://github.com/microsoft/terminal/commit/e6dffdae886a3eba76e3cab330cdc7a6f8c2d6a7) merge main - [`de8a869`](https://github.com/microsoft/terminal/commit/de8a8696bf58f171541f251a74958e3e4ffbdb20) format - [`26652fe`](https://github.com/microsoft/terminal/commit/26652fe3823216a2b0c261848e480969e52d4475) left align actions - [`cefa906`](https://github.com/microsoft/terminal/commit/cefa9068d36cdb0dd4dfb65ff579ab4f07a7a7d7) add more margin for scroll bar ### 📊 Changes **14 files changed** (+933 additions, -127 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Actions.xaml` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+13 -9) 📝 `src/cascadia/TerminalSettingsEditor/CommonResources.xaml` (+647 -24) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.xaml` (+20 -11) 📝 `src/cascadia/TerminalSettingsEditor/Interaction.xaml` (+20 -11) 📝 `src/cascadia/TerminalSettingsEditor/Launch.xaml` (+43 -24) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+2 -3) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.xaml` (+21 -13) 📝 `src/cascadia/TerminalSettingsEditor/Rendering.xaml` (+4 -2) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+7 -11) 📝 `src/cascadia/TerminalSettingsEditor/SettingContainer.cpp` (+21 -0) 📝 `src/cascadia/TerminalSettingsEditor/SettingContainer.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/SettingContainer.idl` (+3 -0) 📝 `src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml` (+130 -19) </details> ### 📄 Description ## Summary of the Pull Request Updates our SUI to follow the windows 11 style guidelines. Includes updating our setting containers to follow the 'expander' style. ## PR Checklist * [x] Closes #10631 * [x] Closes #9978 * [x] Closes #9595 * [x] Closes #11231 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:21 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28718