starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11764] [MERGED] Use nearby fonts for font fallback #28725

New Issue
Open
opened 2026-01-31 09:30:23 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:30:23 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11764
Author: @lhecker
Created: 11/15/2021
Status: ✅ Merged
Merged: 11/16/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/issue-11032-font-fallback

📝 Commits (3)

  • 85c7307 Use nearby fonts for font fallback
  • 5f7e4e6 Fix it for the settings UI as well
  • 8b3001d Fix spell check

📊 Changes

9 files changed (+114 additions, -60 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+50 -2)
📝 src/cascadia/TerminalSettingsEditor/pch.h (+2 -3)
📝 src/renderer/dx/DxFontInfo.cpp (+41 -39)
📝 src/renderer/dx/DxFontInfo.h (+4 -2)
📝 src/renderer/dx/DxFontRenderData.cpp (+2 -2)
📝 src/renderer/dx/DxFontRenderData.h (+1 -1)
📝 src/renderer/dx/lib/dx.vcxproj (+5 -5)
📝 src/renderer/dx/lib/dx.vcxproj.filters (+8 -6)

📄 Description

This commit is a minimal fix in order to pass the
IDWriteFontCollection we create out of .ttf files residing next to our
binaries to the IDWriteFontFallback::MapCharacters call. The
IDWriteTextFormat is used in order to carry the font collection over
into CustomTextLayout.

Validation

  • Put JetBrainsMono-Regular.ttf into the binary output directory
  • Modify HKCU:\Console\*\FaceName to JetBrains Mono
  • Launch OpenConsole.exe
  • OpenConsole uses JetBrains Mono ✔️

Closes #11032
Closes #11648

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11764 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 11/15/2021 **Status:** ✅ Merged **Merged:** 11/16/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/issue-11032-font-fallback` --- ### 📝 Commits (3) - [`85c7307`](https://github.com/microsoft/terminal/commit/85c7307a3bce9d9f69ef65c341e0dfc9731ddb0f) Use nearby fonts for font fallback - [`5f7e4e6`](https://github.com/microsoft/terminal/commit/5f7e4e67ca6724f24bc1502313746cdd2780f13e) Fix it for the settings UI as well - [`8b3001d`](https://github.com/microsoft/terminal/commit/8b3001d4ca99f389d754ead2606d03b83fa6aabd) Fix spell check ### 📊 Changes **9 files changed** (+114 additions, -60 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+50 -2) 📝 `src/cascadia/TerminalSettingsEditor/pch.h` (+2 -3) 📝 `src/renderer/dx/DxFontInfo.cpp` (+41 -39) 📝 `src/renderer/dx/DxFontInfo.h` (+4 -2) 📝 `src/renderer/dx/DxFontRenderData.cpp` (+2 -2) 📝 `src/renderer/dx/DxFontRenderData.h` (+1 -1) 📝 `src/renderer/dx/lib/dx.vcxproj` (+5 -5) 📝 `src/renderer/dx/lib/dx.vcxproj.filters` (+8 -6) </details> ### 📄 Description This commit is a minimal fix in order to pass the `IDWriteFontCollection` we create out of .ttf files residing next to our binaries to the `IDWriteFontFallback::MapCharacters` call. The `IDWriteTextFormat` is used in order to carry the font collection over into `CustomTextLayout`. ## Validation * Put `JetBrainsMono-Regular.ttf` into the binary output directory * Modify `HKCU:\Console\*\FaceName` to `JetBrains Mono` * Launch OpenConsole.exe * OpenConsole uses JetBrains Mono ✔️ Closes #11032 Closes #11648 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:23 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28725
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?