[PR #11808] [MERGED] Fix AltGr not working in the settings UI #28745

Open
opened 2026-01-31 09:30:29 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11808
Author: @lhecker
Created: 11/22/2021
Status: ✅ Merged
Merged: 11/23/2021
Merged by: @undefined

Base: main ← Head: dev/lhecker/issue-11788-altgr-broken


📝 Commits (1)

  • 3ce57c0 Fix AltGr not working in the settings UI

📊 Changes

4 files changed (+178 additions, -44 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+155 -31)
📝 src/cascadia/TerminalApp/TerminalPage.h (+9 -2)
📝 src/cascadia/TerminalControl/TermControl.cpp (+12 -9)
📝 src/cascadia/TerminalControl/TermControl.h (+2 -2)

📄 Description

Since the settings UI's input fields behave similarly to the terminal's input,
TerminalPage::_KeyDownHandler also needs to behave similarly to
TermControl::_KeyHandler. This commit copies all relevant code
over from the latter into the former, including the suppression
of AltGr keys for keychord/action handling.

PR Checklist

Validation Steps Performed

  • Use a German keyboard layout
  • Open 2 regular tabs and 1 settings tab and focus an input field
  • AltGr+2 produces the character ² ✔️
  • Ctrl+Alt+2 opens the second tab ✔️

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11808 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 11/22/2021 **Status:** ✅ Merged **Merged:** 11/23/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/issue-11788-altgr-broken` --- ### 📝 Commits (1) - [`3ce57c0`](https://github.com/microsoft/terminal/commit/3ce57c08031d12dcd1e83a0003cd3e40af55de43) Fix AltGr not working in the settings UI ### 📊 Changes **4 files changed** (+178 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+155 -31) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+9 -2) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+12 -9) 📝 `src/cascadia/TerminalControl/TermControl.h` (+2 -2) </details> ### 📄 Description Since the settings UI's input fields behave similarly to the terminal's input, `TerminalPage::_KeyDownHandler` also needs to behave similarly to `TermControl::_KeyHandler`. This commit copies all relevant code over from the latter into the former, including the suppression of AltGr keys for keychord/action handling. ## PR Checklist * [x] Closes #11788 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Use a German keyboard layout * Open 2 regular tabs and 1 settings tab and focus an input field * AltGr+2 produces the character ² ✔️ * Ctrl+Alt+2 opens the second tab ✔️ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:29 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28745