[PR #11816] [MERGED] Enable /permissive- and remaining /Zc flags #28747

Open
opened 2026-01-31 09:30:30 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11816
Author: @lhecker
Created: 11/24/2021
Status: Merged
Merged: 12/8/2021
Merged by: @undefined

Base: mainHead: dev/lhecker/stricter-conformance


📝 Commits (5)

  • 1d68188 Enable /permissive- and remaining /Zc flags
  • 975a3aa Merge remote-tracking branch 'origin/main' into dev/lhecker/stricter-conformance
  • afd60ca Addressed feedback
  • b3466a3 Fix compilation error
  • 3e43585 Fix formatting

📊 Changes

36 files changed (+268 additions, -393 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/SettingsModel.LocalTests.vcxproj (+2 -1)
📝 src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj (+3 -3)
📝 src/cascadia/TerminalControl/pch.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj (+2 -0)
📝 src/cascadia/UnitTests_TerminalCore/TestUtils.h (+1 -1)
📝 src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj (+2 -1)
📝 src/common.build.pre.props (+3 -1)
📝 src/cppwinrt.build.pre.props (+2 -4)
📝 src/host/_stream.cpp (+1 -1)
📝 src/host/_stream.h (+1 -1)
📝 src/host/alias.cpp (+1 -1)
📝 src/host/alias.h (+1 -1)
📝 src/host/ft_host/API_FileTests.cpp (+1 -1)
📝 src/host/init.cpp (+6 -43)
📝 src/host/tracing.cpp (+1 -1)
📝 src/host/tracing.hpp (+1 -1)
📝 src/host/ut_host/AliasTests.cpp (+6 -6)
📝 src/host/ut_host/ReadWaitTests.cpp (+1 -1)
📝 src/host/ut_host/ScreenBufferTests.cpp (+2 -2)
📝 src/host/ut_host/TextBufferIteratorTests.cpp (+49 -55)

...and 16 more files

📄 Description

This commit enables /permissive- for all projects, as well as all other /Zc
flags not enabled by default by /permissive-. Some projects continue to be
built under /Zc:twoPhase- as JsonUtils.h fails to compile otherwise.

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11816 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 11/24/2021 **Status:** ✅ Merged **Merged:** 12/8/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/stricter-conformance` --- ### 📝 Commits (5) - [`1d68188`](https://github.com/microsoft/terminal/commit/1d6818829e8b43e224cccd67c6331e2040419b28) Enable /permissive- and remaining /Zc flags - [`975a3aa`](https://github.com/microsoft/terminal/commit/975a3aa8223b10cce56daee8d4dc3177996bf7e6) Merge remote-tracking branch 'origin/main' into dev/lhecker/stricter-conformance - [`afd60ca`](https://github.com/microsoft/terminal/commit/afd60ca274a3fb62c1453d5fdad5ca15273742fc) Addressed feedback - [`b3466a3`](https://github.com/microsoft/terminal/commit/b3466a3b4f454dcef422f5b52ba6432b09e5b739) Fix compilation error - [`3e43585`](https://github.com/microsoft/terminal/commit/3e43585492d7a73cac769d08f3f056c2b3909820) Fix formatting ### 📊 Changes **36 files changed** (+268 additions, -393 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/SettingsModel.LocalTests.vcxproj` (+2 -1) 📝 `src/cascadia/LocalTests_TerminalApp/TestHostApp/TestHostApp.vcxproj` (+3 -3) 📝 `src/cascadia/TerminalControl/pch.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/Microsoft.Terminal.Settings.ModelLib.vcxproj` (+2 -0) 📝 `src/cascadia/UnitTests_TerminalCore/TestUtils.h` (+1 -1) 📝 `src/cascadia/ut_app/TerminalApp.UnitTests.vcxproj` (+2 -1) 📝 `src/common.build.pre.props` (+3 -1) 📝 `src/cppwinrt.build.pre.props` (+2 -4) 📝 `src/host/_stream.cpp` (+1 -1) 📝 `src/host/_stream.h` (+1 -1) 📝 `src/host/alias.cpp` (+1 -1) 📝 `src/host/alias.h` (+1 -1) 📝 `src/host/ft_host/API_FileTests.cpp` (+1 -1) 📝 `src/host/init.cpp` (+6 -43) 📝 `src/host/tracing.cpp` (+1 -1) 📝 `src/host/tracing.hpp` (+1 -1) 📝 `src/host/ut_host/AliasTests.cpp` (+6 -6) 📝 `src/host/ut_host/ReadWaitTests.cpp` (+1 -1) 📝 `src/host/ut_host/ScreenBufferTests.cpp` (+2 -2) 📝 `src/host/ut_host/TextBufferIteratorTests.cpp` (+49 -55) _...and 16 more files_ </details> ### 📄 Description This commit enables /permissive- for all projects, as well as all other /Zc flags not enabled by default by /permissive-. Some projects continue to be built under /Zc:twoPhase- as JsonUtils.h fails to compile otherwise. ## PR Checklist * [x] Closes #10703 * [x] I work here * [x] Tests added/passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28747