[PR #11820] [MERGED] Rename IInheritable::InsertParent to improve clarity of intent #28755

Open
opened 2026-01-31 09:30:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11820
Author: @lhecker
Created: 11/24/2021
Status: Merged
Merged: 11/29/2021
Merged by: @undefined

Base: mainHead: dev/lhecker/iinheritable-cleanup


📝 Commits (1)

  • c4efd90 Rename IInheritable::InsertParent to improve clarity of intent

📊 Changes

6 files changed (+19 additions, -20 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp (+5 -5)
📝 src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp (+2 -2)
📝 src/cascadia/TerminalSettingsModel/IInheritable.h (+4 -5)
📝 src/cascadia/TerminalSettingsModel/Profile.cpp (+5 -5)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+1 -1)

📄 Description

This is a followup commit for 168d28b.
By renaming IInheritable::InsertParent(com_ptr) and
InsertParent(size_t, com_ptr) into AddLeastImportantParent(com_ptr)
and AddMostImportantParent(com_ptr) respectively, we can improve
the clarity of our code's intent without the need for comments.

PR Checklist

  • I work here
  • Tests added/passed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11820 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 11/24/2021 **Status:** ✅ Merged **Merged:** 11/29/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/iinheritable-cleanup` --- ### 📝 Commits (1) - [`c4efd90`](https://github.com/microsoft/terminal/commit/c4efd9098b1b852b1a217b91d8b884ee7e9e9f6b) Rename IInheritable::InsertParent to improve clarity of intent ### 📊 Changes **6 files changed** (+19 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp` (+5 -5) 📝 `src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp` (+2 -2) 📝 `src/cascadia/TerminalSettingsModel/IInheritable.h` (+4 -5) 📝 `src/cascadia/TerminalSettingsModel/Profile.cpp` (+5 -5) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+1 -1) </details> ### 📄 Description This is a followup commit for 168d28b. By renaming `IInheritable::InsertParent(com_ptr)` and `InsertParent(size_t, com_ptr)` into `AddLeastImportantParent(com_ptr)` and `AddMostImportantParent(com_ptr)` respectively, we can improve the clarity of our code's intent without the need for comments. ## PR Checklist * [x] I work here * [x] Tests added/passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:33 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28755