[PR #11856] [MERGED] Use more cppwinrt_utils #28768

Open
opened 2026-01-31 09:30:38 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11856
Author: @zadjii-msft
Created: 12/1/2021
Status: Merged
Merged: 12/6/2021
Merged by: @undefined

Base: mainHead: dev/migrie/eim/2456-more-cppwinrt_utils


📝 Commits (7)

  • 753fa35 relative paths are bad, just include this for everyone
  • fe06915 BASIC_FACTORY everything
  • bcf80cd Less of the DECLARE_EVENT/DEFINE_EVENT
  • c6a39f8 FUCK IT just put this in the pch.h for every cppwinrt project, we use it enough
  • e87247e Merge remote-tracking branch 'origin/main' into dev/migrie/eim/2456-more-cppwinrt_utils
  • 07f3aae I totally forgot this project existed
  • 1b13c4d look at that, it was already in the file

📊 Changes

93 files changed (+66 additions, -154 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/pch.h (+2 -0)
📝 src/cascadia/LocalTests_TerminalApp/pch.h (+2 -0)
📝 src/cascadia/Remoting/CommandlineArgs.h (+0 -1)
📝 src/cascadia/Remoting/FindTargetWindowArgs.h (+0 -1)
📝 src/cascadia/Remoting/GetWindowLayoutArgs.h (+0 -1)
📝 src/cascadia/Remoting/Monarch.h (+0 -1)
📝 src/cascadia/Remoting/Peasant.h (+0 -1)
📝 src/cascadia/Remoting/ProposeCommandlineResult.h (+0 -1)
📝 src/cascadia/Remoting/QuitAllRequestedArgs.h (+0 -1)
📝 src/cascadia/Remoting/RenameRequestArgs.h (+0 -1)
📝 src/cascadia/Remoting/SummonWindowBehavior.h (+0 -1)
📝 src/cascadia/Remoting/SummonWindowSelectionArgs.h (+0 -1)
📝 src/cascadia/Remoting/WindowActivatedArgs.h (+0 -1)
📝 src/cascadia/Remoting/WindowManager.h (+0 -1)
📝 src/cascadia/Remoting/pch.h (+2 -0)
📝 src/cascadia/ShellExtension/OpenTerminalHere.h (+0 -1)
📝 src/cascadia/TerminalApp/ActionPaletteItem.h (+0 -1)
📝 src/cascadia/TerminalApp/AppKeyBindings.h (+0 -1)
📝 src/cascadia/TerminalApp/AppLogic.h (+1 -3)
📝 src/cascadia/TerminalApp/ColorPickupFlyout.h (+1 -4)

...and 73 more files

📄 Description

  • Adds the cppwinrt_utils.h to the include path for all winrt projects.
  • Adds the file to the pch.h's for every project, so you don't need to include it in every header.
  • Replaces some usages of DECLARE_EVENT/DEFINE_EVENT with WINRT_CALLBACK, which will do it in a oneliner
  • Adds more BASIC_FACTORY usage.
  • Closes Background Image for cmd (#2456)

It's 92 files with one-line changes, don't be scared.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11856 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/1/2021 **Status:** ✅ Merged **Merged:** 12/6/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/eim/2456-more-cppwinrt_utils` --- ### 📝 Commits (7) - [`753fa35`](https://github.com/microsoft/terminal/commit/753fa3563dd5807bc463fe0c74208f84618df6f5) relative paths are bad, just include this for everyone - [`fe06915`](https://github.com/microsoft/terminal/commit/fe0691552d23bdb82b18adb2d34840808960040a) BASIC_FACTORY everything - [`bcf80cd`](https://github.com/microsoft/terminal/commit/bcf80cda8a22832cee0d097fbd70fe38cd074609) Less of the DECLARE_EVENT/DEFINE_EVENT - [`c6a39f8`](https://github.com/microsoft/terminal/commit/c6a39f8435c37603a1cbe30d24fc47e4c28809e2) FUCK IT just put this in the pch.h for every cppwinrt project, we use it enough - [`e87247e`](https://github.com/microsoft/terminal/commit/e87247e3495f6c146a60f2d48de4b4748fd11633) Merge remote-tracking branch 'origin/main' into dev/migrie/eim/2456-more-cppwinrt_utils - [`07f3aae`](https://github.com/microsoft/terminal/commit/07f3aae3cad0a5c4c312f2ed8407d273c1198fa8) I totally forgot this project existed - [`1b13c4d`](https://github.com/microsoft/terminal/commit/1b13c4d6422c04e5324f45b164a8916a75921d72) look at that, it was already in the file ### 📊 Changes **93 files changed** (+66 additions, -154 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/pch.h` (+2 -0) 📝 `src/cascadia/LocalTests_TerminalApp/pch.h` (+2 -0) 📝 `src/cascadia/Remoting/CommandlineArgs.h` (+0 -1) 📝 `src/cascadia/Remoting/FindTargetWindowArgs.h` (+0 -1) 📝 `src/cascadia/Remoting/GetWindowLayoutArgs.h` (+0 -1) 📝 `src/cascadia/Remoting/Monarch.h` (+0 -1) 📝 `src/cascadia/Remoting/Peasant.h` (+0 -1) 📝 `src/cascadia/Remoting/ProposeCommandlineResult.h` (+0 -1) 📝 `src/cascadia/Remoting/QuitAllRequestedArgs.h` (+0 -1) 📝 `src/cascadia/Remoting/RenameRequestArgs.h` (+0 -1) 📝 `src/cascadia/Remoting/SummonWindowBehavior.h` (+0 -1) 📝 `src/cascadia/Remoting/SummonWindowSelectionArgs.h` (+0 -1) 📝 `src/cascadia/Remoting/WindowActivatedArgs.h` (+0 -1) 📝 `src/cascadia/Remoting/WindowManager.h` (+0 -1) 📝 `src/cascadia/Remoting/pch.h` (+2 -0) 📝 `src/cascadia/ShellExtension/OpenTerminalHere.h` (+0 -1) 📝 `src/cascadia/TerminalApp/ActionPaletteItem.h` (+0 -1) 📝 `src/cascadia/TerminalApp/AppKeyBindings.h` (+0 -1) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+1 -3) 📝 `src/cascadia/TerminalApp/ColorPickupFlyout.h` (+1 -4) _...and 73 more files_ </details> ### 📄 Description * Adds the `cppwinrt_utils.h` to the include path for all winrt projects. * Adds the file to the pch.h's for every project, so you don't need to include it in every header. * Replaces some usages of `DECLARE_EVENT`/`DEFINE_EVENT` with `WINRT_CALLBACK`, which will do it in a oneliner * Adds more `BASIC_FACTORY` usage. * [x] Closes #2456 It's 92 files with one-line changes, don't be scared. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:38 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28768